Re: [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c

2013-12-15 Thread Borislav Petkov
On Sat, Dec 14, 2013 at 12:28:12PM -0800, Josh Triplett wrote: > On Sat, Dec 14, 2013 at 07:28:24PM +0530, Rashika Kheria wrote: > > This patch marks the function amd64_decode_bus_error() as static in > > amd64_edac.c because it is not used outside this file. > > > > Thus, it also eliminates the f

Re: [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c

2013-12-14 Thread Borislav Petkov
On Sat, Dec 14, 2013 at 11:47:10PM +0530, Rashika Kheria wrote: > My gcc version is 4.6.3. You can trigger these warnings by adding > -Wmissing-prototypes to KBUILD_CFLAGS in the top-level Makefile, and Actually, you don't even have to do that - you only need to build with W=1: make W=1 drivers/e

Re: [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c

2013-12-14 Thread Josh Triplett
On Sat, Dec 14, 2013 at 07:28:24PM +0530, Rashika Kheria wrote: > This patch marks the function amd64_decode_bus_error() as static in > amd64_edac.c because it is not used outside this file. > > Thus, it also eliminates the following warning in amd64_edac.c: > drivers/edac/amd64_edac.c:2038:6: war

Re: [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c

2013-12-14 Thread Rashika Kheria
On Sat, Dec 14, 2013 at 10:31 PM, Borislav Petkov wrote: > On Sat, Dec 14, 2013 at 07:28:24PM +0530, Rashika Kheria wrote: >> This patch marks the function amd64_decode_bus_error() as static in >> amd64_edac.c because it is not used outside this file. >> >> Thus, it also eliminates the following w

Re: [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c

2013-12-14 Thread Borislav Petkov
On Sat, Dec 14, 2013 at 07:28:24PM +0530, Rashika Kheria wrote: > This patch marks the function amd64_decode_bus_error() as static in > amd64_edac.c because it is not used outside this file. > > Thus, it also eliminates the following warning in amd64_edac.c: > drivers/edac/amd64_edac.c:2038:6: war

[PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c

2013-12-14 Thread Rashika Kheria
This patch marks the function amd64_decode_bus_error() as static in amd64_edac.c because it is not used outside this file. Thus, it also eliminates the following warning in amd64_edac.c: drivers/edac/amd64_edac.c:2038:6: warning: no previous prototype for ‘amd64_decode_bus_error’ [-Wmissing-proto