Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-16 Thread Linus Walleij
On Fri, Jun 14, 2013 at 12:02 AM, Stephen Warren wrote: > On 06/11/2013 02:28 AM, Linus Walleij wrote: >> I tried to create a refactoring patch for this but couldn't come >> up with anything apropriate along the lines above. For example >> this function: > ... > > Don't you just want something

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-16 Thread Linus Walleij
On Fri, Jun 14, 2013 at 12:02 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 06/11/2013 02:28 AM, Linus Walleij wrote: I tried to create a refactoring patch for this but couldn't come up with anything apropriate along the lines above. For example this function: ... Don't you just want

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-13 Thread Stephen Warren
On 06/11/2013 02:28 AM, Linus Walleij wrote: > On Wed, Jun 5, 2013 at 7:22 PM, Stephen Warren wrote: > >>> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c >> >>> +int pinctrl_pm_select_default_state(struct device *dev) >> >>> +int pinctrl_pm_select_sleep_state(struct device *dev) >>

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-13 Thread Stephen Warren
On 06/11/2013 02:28 AM, Linus Walleij wrote: On Wed, Jun 5, 2013 at 7:22 PM, Stephen Warren swar...@wwwdotorg.org wrote: diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c +int pinctrl_pm_select_default_state(struct device *dev) +int pinctrl_pm_select_sleep_state(struct device

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-11 Thread Linus Walleij
On Wed, Jun 5, 2013 at 7:22 PM, Stephen Warren wrote: >> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c > >> +int pinctrl_pm_select_default_state(struct device *dev) > >> +int pinctrl_pm_select_sleep_state(struct device *dev) > >> +int pinctrl_pm_select_idle_state(struct device

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-11 Thread Linus Walleij
On Wed, Jun 5, 2013 at 7:22 PM, Stephen Warren swar...@wwwdotorg.org wrote: diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c +int pinctrl_pm_select_default_state(struct device *dev) +int pinctrl_pm_select_sleep_state(struct device *dev) +int pinctrl_pm_select_idle_state(struct

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-07 Thread Linus Walleij
On Wed, Jun 5, 2013 at 7:22 PM, Stephen Warren wrote: >> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c > >> +int pinctrl_pm_select_default_state(struct device *dev) > >> +int pinctrl_pm_select_sleep_state(struct device *dev) > >> +int pinctrl_pm_select_idle_state(struct device

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-07 Thread Linus Walleij
On Wed, Jun 5, 2013 at 7:22 PM, Stephen Warren swar...@wwwdotorg.org wrote: diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c +int pinctrl_pm_select_default_state(struct device *dev) +int pinctrl_pm_select_sleep_state(struct device *dev) +int pinctrl_pm_select_idle_state(struct

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2013 at 03:44:31PM +0200, Linus Walleij wrote: > From: Linus Walleij > > If a device have sleep and idle states in addition to the > default state, look up these in the core and stash them in > the pinctrl state container. > > Add accessor functions for pinctrl consumers to put

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Stephen Warren
On 06/05/2013 07:44 AM, Linus Walleij wrote: > From: Linus Walleij > > If a device have sleep and idle states in addition to the > default state, look up these in the core and stash them in > the pinctrl state container. > > Add accessor functions for pinctrl consumers to put the pins > into

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Kevin Hilman
Linus Walleij writes: > From: Linus Walleij > > If a device have sleep and idle states in addition to the > default state, look up these in the core and stash them in > the pinctrl state container. > > Add accessor functions for pinctrl consumers to put the pins > into "default", "sleep" and

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Mark Brown
On Wed, Jun 05, 2013 at 03:44:31PM +0200, Linus Walleij wrote: > From: Linus Walleij > > If a device have sleep and idle states in addition to the > default state, look up these in the core and stash them in > the pinctrl state container. > > Add accessor functions for pinctrl consumers to put

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Wolfram Sang
On Wed, Jun 05, 2013 at 03:44:31PM +0200, Linus Walleij wrote: > From: Linus Walleij > > If a device have sleep and idle states in addition to the > default state, look up these in the core and stash them in > the pinctrl state container. > > Add accessor functions for pinctrl consumers to put

[PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Linus Walleij
From: Linus Walleij If a device have sleep and idle states in addition to the default state, look up these in the core and stash them in the pinctrl state container. Add accessor functions for pinctrl consumers to put the pins into "default", "sleep" and "idle" states passing nothing but the

[PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org If a device have sleep and idle states in addition to the default state, look up these in the core and stash them in the pinctrl state container. Add accessor functions for pinctrl consumers to put the pins into default, sleep and idle states passing

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Wolfram Sang
On Wed, Jun 05, 2013 at 03:44:31PM +0200, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org If a device have sleep and idle states in addition to the default state, look up these in the core and stash them in the pinctrl state container. Add accessor functions for pinctrl

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Mark Brown
On Wed, Jun 05, 2013 at 03:44:31PM +0200, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org If a device have sleep and idle states in addition to the default state, look up these in the core and stash them in the pinctrl state container. Add accessor functions for pinctrl

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Kevin Hilman
Linus Walleij linus.wall...@stericsson.com writes: From: Linus Walleij linus.wall...@linaro.org If a device have sleep and idle states in addition to the default state, look up these in the core and stash them in the pinctrl state container. Add accessor functions for pinctrl consumers to

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Stephen Warren
On 06/05/2013 07:44 AM, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org If a device have sleep and idle states in addition to the default state, look up these in the core and stash them in the pinctrl state container. Add accessor functions for pinctrl consumers to put

Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

2013-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2013 at 03:44:31PM +0200, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org If a device have sleep and idle states in addition to the default state, look up these in the core and stash them in the pinctrl state container. Add accessor functions for pinctrl