Re: [PATCH 1/3] drm/mediatek: move mipi_dsi_host_register to probe

2019-02-17 Thread Jitao Shi
On Thu, 2019-02-14 at 14:02 +0800, Nicolas Boichat wrote: > Just some comments on the error path, I'm not sure about the change itself. > > On Thu, Feb 14, 2019 at 12:42 PM Jitao Shi wrote: > > > > DSI panel driver need attach function which is inculde in > > mipi_dsi_host_ops. > > > > If mipi_ds

Re: [PATCH 1/3] drm/mediatek: move mipi_dsi_host_register to probe

2019-02-17 Thread Jitao Shi
On Thu, 2019-02-14 at 15:48 -0500, Sean Paul wrote: > On Thu, Feb 14, 2019 at 12:42:41PM +0800, Jitao Shi wrote: > > DSI panel driver need attach function which is inculde in > > mipi_dsi_host_ops. > > Which function is required from dsi_host? > > Sean > mipi_dsi_attach request the mipi_dsi_hos

Re: [PATCH 1/3] drm/mediatek: move mipi_dsi_host_register to probe

2019-02-14 Thread Sean Paul
On Thu, Feb 14, 2019 at 12:42:41PM +0800, Jitao Shi wrote: > DSI panel driver need attach function which is inculde in > mipi_dsi_host_ops. Which function is required from dsi_host? Sean > > If mipi_dsi_host_register is not in probe, dsi panel will > probe fail or more delay. > > So move the m

Re: [PATCH 1/3] drm/mediatek: move mipi_dsi_host_register to probe

2019-02-13 Thread Nicolas Boichat
Just some comments on the error path, I'm not sure about the change itself. On Thu, Feb 14, 2019 at 12:42 PM Jitao Shi wrote: > > DSI panel driver need attach function which is inculde in > mipi_dsi_host_ops. > > If mipi_dsi_host_register is not in probe, dsi panel will > probe fail or more delay

[PATCH 1/3] drm/mediatek: move mipi_dsi_host_register to probe

2019-02-13 Thread Jitao Shi
DSI panel driver need attach function which is inculde in mipi_dsi_host_ops. If mipi_dsi_host_register is not in probe, dsi panel will probe fail or more delay. So move the mipi_dsi_host_register to probe from bind. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 49 +