Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-09 Thread Jeff Garzik
Kok, Auke wrote: Personally, I think this is really really needed. I'm surprised that you already didn't push this considering Andrew pulled this into -mm immediately. Since it affects a fragile area of e1000 for all [e1000] users, I much prefer to err on the side of caution. I have a

Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-09 Thread Kok, Auke
Jeff Garzik wrote: Auke Kok wrote: From: Auke Kok <[EMAIL PROTECTED]> DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq.

Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-09 Thread Jeff Garzik
Auke Kok wrote: From: Auke Kok <[EMAIL PROTECTED]> DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq. Signed-off-by: Auke

Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-09 Thread Jeff Garzik
Auke Kok wrote: From: Auke Kok [EMAIL PROTECTED] DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq. Signed-off-by: Auke

Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-09 Thread Kok, Auke
Jeff Garzik wrote: Auke Kok wrote: From: Auke Kok [EMAIL PROTECTED] DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq.

Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-09 Thread Jeff Garzik
Kok, Auke wrote: Personally, I think this is really really needed. I'm surprised that you already didn't push this considering Andrew pulled this into -mm immediately. Since it affects a fragile area of e1000 for all [e1000] users, I much prefer to err on the side of caution. I have a

[PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-06 Thread Auke Kok
From: Auke Kok <[EMAIL PROTECTED]> DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq. Signed-off-by: Auke Kok <[EMAIL

[PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-06 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq. Signed-off-by: Auke Kok [EMAIL