Re: [PATCH 1/3] ext4: Add alignment check for DAX mount

2016-05-02 Thread Toshi Kani
On Mon, 2016-05-02 at 12:49 +0300, Boaz Harrosh wrote: > On 05/01/2016 08:31 PM, Christoph Hellwig wrote: > > > > On Fri, Apr 29, 2016 at 02:39:33PM -0600, Toshi Kani wrote: > > > > > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > > > index 304c712..90a8670 100644 > > > --- a/fs/ext4/super.c

Re: [PATCH 1/3] ext4: Add alignment check for DAX mount

2016-05-02 Thread Boaz Harrosh
On 05/01/2016 08:31 PM, Christoph Hellwig wrote: > On Fri, Apr 29, 2016 at 02:39:33PM -0600, Toshi Kani wrote: >> diff --git a/fs/ext4/super.c b/fs/ext4/super.c >> index 304c712..90a8670 100644 >> --- a/fs/ext4/super.c >> +++ b/fs/ext4/super.c >> @@ -3421,6 +3421,12 @@ static int ext4_fill_super(st

Re: [PATCH 1/3] ext4: Add alignment check for DAX mount

2016-05-01 Thread Christoph Hellwig
On Fri, Apr 29, 2016 at 02:39:33PM -0600, Toshi Kani wrote: > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index 304c712..90a8670 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -3421,6 +3421,12 @@ static int ext4_fill_super(struct super_block *sb, > void *data, int silent) >

Re: [PATCH 1/3] ext4: Add alignment check for DAX mount

2016-05-01 Thread Boaz Harrosh
On 04/29/2016 11:39 PM, Toshi Kani wrote: > When a partition is not aligned by 4KB, mount -o dax succeeds, > but any read/write access to the filesystem fails, except for > metadata update. > > Add alignment check to ext4_fill_super() when -o dax is specified. > > Reported-by: Micah Parrish > Si

[PATCH 1/3] ext4: Add alignment check for DAX mount

2016-04-29 Thread Toshi Kani
When a partition is not aligned by 4KB, mount -o dax succeeds, but any read/write access to the filesystem fails, except for metadata update. Add alignment check to ext4_fill_super() when -o dax is specified. Reported-by: Micah Parrish Signed-off-by: Toshi Kani Cc: "Theodore Ts'o" Cc: Andreas