Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas

2016-10-10 Thread atull
On Thu, 6 Oct 2016, Joshua Clayton wrote: > cyclonespi loads fpga firmware over spi, using the "passive serial" > interface on Altera Cyclone FPGAS. > > one of the simpler ways to set up an fpga at runtime. > The signal interface is close to unidirectional spi with lsb first. > > Signed-off-by:

Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas

2016-10-10 Thread atull
On Fri, 7 Oct 2016, Moritz Fischer wrote: > Hi Alan, > > On Fri, Oct 7, 2016 at 11:21 AM, atull wrote: > > > Moritz, Can you remind me what that issue was there (or point me to > > that email, I can't find it)? I don't think I had a problem with that > > in your case. In general I think if th

Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas

2016-10-07 Thread Joshua Clayton
On 10/07/2016 11:21 AM, atull wrote: > On Fri, 7 Oct 2016, Moritz Fischer wrote: > >>> +static inline u32 revbit8x4(u32 n) >>> +{ >>> + n = ((n & 0xF0F0F0F0UL) >> 4) | ((n & 0x0F0F0F0FUL) << 4); >>> + n = ((n & 0xUL) >> 2) | ((n & 0xUL) << 2); >>> + n = ((n & 0xAA

Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas

2016-10-07 Thread Moritz Fischer
Hi Alan, On Fri, Oct 7, 2016 at 11:21 AM, atull wrote: > Moritz, Can you remind me what that issue was there (or point me to > that email, I can't find it)? I don't think I had a problem with that > in your case. In general I think if these drivers can take the > bitstream that comes from the

Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas

2016-10-07 Thread atull
On Fri, 7 Oct 2016, Moritz Fischer wrote: > > +static inline u32 revbit8x4(u32 n) > > +{ > > + n = ((n & 0xF0F0F0F0UL) >> 4) | ((n & 0x0F0F0F0FUL) << 4); > > + n = ((n & 0xUL) >> 2) | ((n & 0xUL) << 2); > > + n = ((n & 0xUL) >> 1) | ((n & 0xUL) <<

Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas

2016-10-06 Thread Moritz Fischer
Hi Joshua, couple of nits inline below: On Thu, Oct 6, 2016 at 1:34 PM, Joshua Clayton wrote: > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index cd84934..ccad5b1 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -13,6 +13,12 @@ config FPGA > > if FPGA > > +c

[PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas

2016-10-06 Thread Joshua Clayton
cyclonespi loads fpga firmware over spi, using the "passive serial" interface on Altera Cyclone FPGAS. one of the simpler ways to set up an fpga at runtime. The signal interface is close to unidirectional spi with lsb first. Signed-off-by: Joshua Clayton --- drivers/fpga/Kconfig | 6 ++