Re: [PATCH 1/3] fs/efs: Use correct brace styling for statements

2021-02-04 Thread Amy Parker
On Thu, Feb 4, 2021 at 9:09 PM Chaitanya Kulkarni wrote: > > On 2/4/21 21:01, Amy Parker wrote: > >> Commit message is too long. Follow the style present in the tree. > > Are you referring to the per-line length? That was supposed to have > > been broken up, my apologies. Or is it the overall leng

Re: [PATCH 1/3] fs/efs: Use correct brace styling for statements

2021-02-04 Thread Chaitanya Kulkarni
On 2/4/21 21:01, Amy Parker wrote: >> Commit message is too long. Follow the style present in the tree. > Are you referring to the per-line length? That was supposed to have > been broken up, my apologies. Or is it the overall length that is the > issue? > >-Amy IP > Per line length. I think it

Re: [PATCH 1/3] fs/efs: Use correct brace styling for statements

2021-02-04 Thread Amy Parker
On Thu, Feb 4, 2021 at 8:57 PM Chaitanya Kulkarni wrote: > > On 2/4/21 20:55, Amy Parker wrote: > > Many single-line statements have unnecessary braces, and some statement > > pairs have mismatched braces. This is a clear violation of the kernel style > > guide, which mandates that single line s

Re: [PATCH 1/3] fs/efs: Use correct brace styling for statements

2021-02-04 Thread Chaitanya Kulkarni
On 2/4/21 20:55, Amy Parker wrote: > Many single-line statements have unnecessary braces, and some statement pairs > have mismatched braces. This is a clear violation of the kernel style guide, > which mandates that single line statements have no braces and that pairs with > at least one multi-l

[PATCH 1/3] fs/efs: Use correct brace styling for statements

2021-02-04 Thread Amy Parker
Many single-line statements have unnecessary braces, and some statement pairs have mismatched braces. This is a clear violation of the kernel style guide, which mandates that single line statements have no braces and that pairs with at least one multi-line block maintain their braces. This patc