Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-05 Thread Andy Lutomirski
On Wed, Nov 5, 2014 at 9:21 AM, David Drysdale wrote: > On Tue, Nov 4, 2014 at 9:40 AM, David Drysdale wrote: >> On Mon, Nov 3, 2014 at 5:22 PM, Eric W.Biederman >> wrote: >>> On November 3, 2014 7:42:58 AM PST, Andy Lutomirski >>> wrote: On Mon, Nov 3, 2014 at 7:20 AM, Al Viro

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-05 Thread David Drysdale
On Tue, Nov 4, 2014 at 9:40 AM, David Drysdale wrote: > On Mon, Nov 3, 2014 at 5:22 PM, Eric W.Biederman > wrote: >> On November 3, 2014 7:42:58 AM PST, Andy Lutomirski >> wrote: >>>On Mon, Nov 3, 2014 at 7:20 AM, Al Viro >>>wrote: On Mon, Nov 03, 2014 at 11:48:23AM +, David

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-05 Thread David Drysdale
On Tue, Nov 4, 2014 at 9:40 AM, David Drysdale drysd...@google.com wrote: On Mon, Nov 3, 2014 at 5:22 PM, Eric W.Biederman ebied...@xmission.com wrote: On November 3, 2014 7:42:58 AM PST, Andy Lutomirski l...@amacapital.net wrote: On Mon, Nov 3, 2014 at 7:20 AM, Al Viro

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-05 Thread Andy Lutomirski
On Wed, Nov 5, 2014 at 9:21 AM, David Drysdale drysd...@google.com wrote: On Tue, Nov 4, 2014 at 9:40 AM, David Drysdale drysd...@google.com wrote: On Mon, Nov 3, 2014 at 5:22 PM, Eric W.Biederman ebied...@xmission.com wrote: On November 3, 2014 7:42:58 AM PST, Andy Lutomirski

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-04 Thread David Drysdale
On Mon, Nov 3, 2014 at 5:22 PM, Eric W.Biederman wrote: > On November 3, 2014 7:42:58 AM PST, Andy Lutomirski > wrote: >>On Mon, Nov 3, 2014 at 7:20 AM, Al Viro >>wrote: >>> On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote: Add a new O_BENEATH flag for openat(2) which

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-04 Thread David Drysdale
On Mon, Nov 3, 2014 at 5:22 PM, Eric W.Biederman ebied...@xmission.com wrote: On November 3, 2014 7:42:58 AM PST, Andy Lutomirski l...@amacapital.net wrote: On Mon, Nov 3, 2014 at 7:20 AM, Al Viro v...@zeniv.linux.org.uk wrote: On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote:

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Andy Lutomirski
On Mon, Nov 3, 2014 at 10:25 AM, Julien Tinnes wrote: > On Mon, Nov 3, 2014 at 9:37 AM, David Drysdale wrote: >> >> On Mon, Nov 3, 2014 at 3:42 PM, Andy Lutomirski >> wrote: >> > On Mon, Nov 3, 2014 at 7:20 AM, Al Viro wrote: >> >> On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Julien Tinnes
On Mon, Nov 3, 2014 at 9:37 AM, David Drysdale wrote: > On Mon, Nov 3, 2014 at 3:42 PM, Andy Lutomirski wrote: >> This is extremely useful in conjunction with seccomp. > > Yes, that was my understanding of how the Chrome[OS] folk wanted > to use it. Yes, exactly. Without this, if we want to

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread David Drysdale
On Mon, Nov 3, 2014 at 3:42 PM, Andy Lutomirski wrote: > On Mon, Nov 3, 2014 at 7:20 AM, Al Viro wrote: >> On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote: >>> Add a new O_BENEATH flag for openat(2) which restricts the >>> provided path, rejecting (with -EACCES) paths that are not

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Eric W.Biederman
On November 3, 2014 7:42:58 AM PST, Andy Lutomirski wrote: >On Mon, Nov 3, 2014 at 7:20 AM, Al Viro >wrote: >> On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote: >>> Add a new O_BENEATH flag for openat(2) which restricts the >>> provided path, rejecting (with -EACCES) paths that

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Andy Lutomirski
On Mon, Nov 3, 2014 at 7:20 AM, Al Viro wrote: > On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote: >> Add a new O_BENEATH flag for openat(2) which restricts the >> provided path, rejecting (with -EACCES) paths that are not beneath >> the provided dfd. In particular, reject: >> -

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Al Viro
On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote: > Add a new O_BENEATH flag for openat(2) which restricts the > provided path, rejecting (with -EACCES) paths that are not beneath > the provided dfd. In particular, reject: > - paths that contain .. components > - paths that begin

[PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread David Drysdale
Add a new O_BENEATH flag for openat(2) which restricts the provided path, rejecting (with -EACCES) paths that are not beneath the provided dfd. In particular, reject: - paths that contain .. components - paths that begin with / - symlinks that have paths as above. Signed-off-by: David

[PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread David Drysdale
Add a new O_BENEATH flag for openat(2) which restricts the provided path, rejecting (with -EACCES) paths that are not beneath the provided dfd. In particular, reject: - paths that contain .. components - paths that begin with / - symlinks that have paths as above. Signed-off-by: David

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Al Viro
On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote: Add a new O_BENEATH flag for openat(2) which restricts the provided path, rejecting (with -EACCES) paths that are not beneath the provided dfd. In particular, reject: - paths that contain .. components - paths that begin with

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Andy Lutomirski
On Mon, Nov 3, 2014 at 7:20 AM, Al Viro v...@zeniv.linux.org.uk wrote: On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote: Add a new O_BENEATH flag for openat(2) which restricts the provided path, rejecting (with -EACCES) paths that are not beneath the provided dfd. In particular,

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Eric W.Biederman
On November 3, 2014 7:42:58 AM PST, Andy Lutomirski l...@amacapital.net wrote: On Mon, Nov 3, 2014 at 7:20 AM, Al Viro v...@zeniv.linux.org.uk wrote: On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote: Add a new O_BENEATH flag for openat(2) which restricts the provided path,

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread David Drysdale
On Mon, Nov 3, 2014 at 3:42 PM, Andy Lutomirski l...@amacapital.net wrote: On Mon, Nov 3, 2014 at 7:20 AM, Al Viro v...@zeniv.linux.org.uk wrote: On Mon, Nov 03, 2014 at 11:48:23AM +, David Drysdale wrote: Add a new O_BENEATH flag for openat(2) which restricts the provided path, rejecting

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Julien Tinnes
On Mon, Nov 3, 2014 at 9:37 AM, David Drysdale drysd...@google.com wrote: On Mon, Nov 3, 2014 at 3:42 PM, Andy Lutomirski l...@amacapital.net wrote: This is extremely useful in conjunction with seccomp. Yes, that was my understanding of how the Chrome[OS] folk wanted to use it. Yes, exactly.

Re: [PATCH 1/3] fs: add O_BENEATH flag to openat(2)

2014-11-03 Thread Andy Lutomirski
On Mon, Nov 3, 2014 at 10:25 AM, Julien Tinnes j...@chromium.org wrote: On Mon, Nov 3, 2014 at 9:37 AM, David Drysdale drysd...@google.com wrote: On Mon, Nov 3, 2014 at 3:42 PM, Andy Lutomirski l...@amacapital.net wrote: On Mon, Nov 3, 2014 at 7:20 AM, Al Viro v...@zeniv.linux.org.uk wrote: