Re: [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip()

2014-03-31 Thread Jamie Iles
On Tue, Mar 25, 2014 at 09:37:50PM +0100, Linus Walleij wrote: > Aha Jamie not even on the original thread. Here. > > On Tue, Mar 25, 2014 at 9:37 PM, Linus Walleij > wrote: > > On Thu, Mar 20, 2014 at 8:55 PM, Sebastian Andrzej Siewior > > wrote: > > > >> This looks kinda wrong I didn't manage

Re: [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip()

2014-03-25 Thread Linus Walleij
Aha Jamie not even on the original thread. Here. On Tue, Mar 25, 2014 at 9:37 PM, Linus Walleij wrote: > On Thu, Mar 20, 2014 at 8:55 PM, Sebastian Andrzej Siewior > wrote: > >> This looks kinda wrong I didn't manage to fully test it. >> The driver calls irq_alloc_domain_generic_chips() which cr

Re: [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip()

2014-03-25 Thread Linus Walleij
On Thu, Mar 20, 2014 at 8:55 PM, Sebastian Andrzej Siewior wrote: > This looks kinda wrong I didn't manage to fully test it. > The driver calls irq_alloc_domain_generic_chips() which creates a gc and > adds it to gc_list. The driver later then calls irq_setup_generic_chip() > which also initializ

[PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip()

2014-03-20 Thread Sebastian Andrzej Siewior
This looks kinda wrong I didn't manage to fully test it. The driver calls irq_alloc_domain_generic_chips() which creates a gc and adds it to gc_list. The driver later then calls irq_setup_generic_chip() which also initializes the gc and adds it to the gc_list() and this corrupts the list. I can't f