Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-16 Thread Linus Walleij
On Thu, Nov 8, 2018 at 5:53 PM Bartosz Golaszewski wrote: > Commit 3edfb7bd76bd ("gpiolib: Show correct direction from the > beginning") fixed an existing issue but broke libgpiod tests by > changing the default direction of dummy lines to output. > > We don't break user-space so make gpio-mockup

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-12 Thread Uwe Kleine-König
Hello Bartosz, On Mon, Nov 12, 2018 at 03:14:31PM +0100, Bartosz Golaszewski wrote: > > > As I said before: it is and should be fixed in this specific case. > > > This isn't real hardware. Not being "real hardware" is hardly an argument that matters here. > > Not sure if we agree here yet. What

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-12 Thread Bartosz Golaszewski
niedz., 11 lis 2018 o 17:59 Uwe Kleine-König napisał(a): > > On Fri, Nov 09, 2018 at 06:23:01PM +0100, Bartosz Golaszewski wrote: > > pt., 9 lis 2018 o 18:03 Uwe Kleine-König > > napisał(a): > > > > > > Hello Bartosz, > > > > > > On Fri, Nov 09, 2018 at 04:24:10PM +0100, Bartosz Golaszewski wrote

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-11 Thread Uwe Kleine-König
On Fri, Nov 09, 2018 at 06:23:01PM +0100, Bartosz Golaszewski wrote: > pt., 9 lis 2018 o 18:03 Uwe Kleine-König > napisał(a): > > > > Hello Bartosz, > > > > On Fri, Nov 09, 2018 at 04:24:10PM +0100, Bartosz Golaszewski wrote: > > > pt., 9 lis 2018 o 15:39 Uwe Kleine-König > > > napisał(a): > > >

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-09 Thread Bartosz Golaszewski
pt., 9 lis 2018 o 18:03 Uwe Kleine-König napisał(a): > > Hello Bartosz, > > On Fri, Nov 09, 2018 at 04:24:10PM +0100, Bartosz Golaszewski wrote: > > pt., 9 lis 2018 o 15:39 Uwe Kleine-König > > napisał(a): > > > On Fri, Nov 09, 2018 at 02:53:16PM +0100, Bartosz Golaszewski wrote: > > > > pt., 9 l

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-09 Thread Uwe Kleine-König
Hello Bartosz, On Fri, Nov 09, 2018 at 04:24:10PM +0100, Bartosz Golaszewski wrote: > pt., 9 lis 2018 o 15:39 Uwe Kleine-König > napisał(a): > > On Fri, Nov 09, 2018 at 02:53:16PM +0100, Bartosz Golaszewski wrote: > > > pt., 9 lis 2018 o 14:10 Uwe Kleine-König > > > napisał(a): > > > > Which tes

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-09 Thread Bartosz Golaszewski
pt., 9 lis 2018 o 15:39 Uwe Kleine-König napisał(a): > > On Fri, Nov 09, 2018 at 02:53:16PM +0100, Bartosz Golaszewski wrote: > > pt., 9 lis 2018 o 14:10 Uwe Kleine-König > > napisał(a): > > > > > > Hello, > > > > > > On Fri, Nov 09, 2018 at 01:24:36PM +0100, Bartosz Golaszewski wrote: > > > > pt

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-09 Thread Uwe Kleine-König
On Fri, Nov 09, 2018 at 02:53:16PM +0100, Bartosz Golaszewski wrote: > pt., 9 lis 2018 o 14:10 Uwe Kleine-König > napisał(a): > > > > Hello, > > > > On Fri, Nov 09, 2018 at 01:24:36PM +0100, Bartosz Golaszewski wrote: > > > pt., 9 lis 2018 o 12:54 Uwe Kleine-König > > > napisał(a): > > > > On Fri

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-09 Thread Bartosz Golaszewski
pt., 9 lis 2018 o 14:10 Uwe Kleine-König napisał(a): > > Hello, > > On Fri, Nov 09, 2018 at 01:24:36PM +0100, Bartosz Golaszewski wrote: > > pt., 9 lis 2018 o 12:54 Uwe Kleine-König > > napisał(a): > > > On Fri, Nov 09, 2018 at 12:13:44PM +0100, Bartosz Golaszewski wrote: > > > > czw., 8 lis 2018

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-09 Thread Uwe Kleine-König
Hello, On Fri, Nov 09, 2018 at 01:24:36PM +0100, Bartosz Golaszewski wrote: > pt., 9 lis 2018 o 12:54 Uwe Kleine-König > napisał(a): > > On Fri, Nov 09, 2018 at 12:13:44PM +0100, Bartosz Golaszewski wrote: > > > czw., 8 lis 2018 o 21:35 Uwe Kleine-König > > > napisał(a): > > > > On Thu, Nov 08,

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-09 Thread Bartosz Golaszewski
pt., 9 lis 2018 o 12:54 Uwe Kleine-König napisał(a): > > Hello Bartosz, > > On Fri, Nov 09, 2018 at 12:13:44PM +0100, Bartosz Golaszewski wrote: > > czw., 8 lis 2018 o 21:35 Uwe Kleine-König > > napisał(a): > > > On Thu, Nov 08, 2018 at 05:52:53PM +0100, Bartosz Golaszewski wrote: > > > > Commit

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-09 Thread Uwe Kleine-König
Hello Bartosz, On Fri, Nov 09, 2018 at 12:13:44PM +0100, Bartosz Golaszewski wrote: > czw., 8 lis 2018 o 21:35 Uwe Kleine-König > napisał(a): > > On Thu, Nov 08, 2018 at 05:52:53PM +0100, Bartosz Golaszewski wrote: > > > Commit 3edfb7bd76bd ("gpiolib: Show correct direction from the > > > beginni

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-09 Thread Bartosz Golaszewski
czw., 8 lis 2018 o 21:35 Uwe Kleine-König napisał(a): > > Hello Bartosz, > > On Thu, Nov 08, 2018 at 05:52:53PM +0100, Bartosz Golaszewski wrote: > > Commit 3edfb7bd76bd ("gpiolib: Show correct direction from the > > beginning") fixed an existing issue but broke libgpiod tests by > > changing the

Re: [PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-08 Thread Uwe Kleine-König
Hello Bartosz, On Thu, Nov 08, 2018 at 05:52:53PM +0100, Bartosz Golaszewski wrote: > Commit 3edfb7bd76bd ("gpiolib: Show correct direction from the > beginning") fixed an existing issue but broke libgpiod tests by > changing the default direction of dummy lines to output. The indicated commit on

[PATCH 1/3] gpio: mockup: fix indicated direction

2018-11-08 Thread Bartosz Golaszewski
Commit 3edfb7bd76bd ("gpiolib: Show correct direction from the beginning") fixed an existing issue but broke libgpiod tests by changing the default direction of dummy lines to output. We don't break user-space so make gpio-mockup behave as before. Signed-off-by: Bartosz Golaszewski --- drivers/