Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Andy Shevchenko
On Wed, Mar 31, 2021 at 4:36 PM Matthias Schiffer wrote: > > On Wed, 2021-03-31 at 15:39 +0300, Andy Shevchenko wrote: > > On Wed, Mar 31, 2021 at 3:37 PM Matthias Schiffer > > wrote: > > > On Wed, 2021-03-31 at 15:29 +0300, Andy Shevchenko wrote: ... > > > I don't understand which part of the

Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:39 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 3:37 PM Matthias Schiffer > wrote: > > On Wed, 2021-03-31 at 15:29 +0300, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer > > > wrote: > > ... > > > > > - irq =

Re: (EXT) Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Andy Shevchenko
On Wed, Mar 31, 2021 at 3:37 PM Matthias Schiffer wrote: > On Wed, 2021-03-31 at 15:29 +0300, Andy Shevchenko wrote: > > On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer > > wrote: ... > > > - irq = platform_get_irq(pdev, 0); > > > - if (irq < 0) > > > + irq =

Re: (EXT) Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Matthias Schiffer
On Wed, 2021-03-31 at 15:29 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer > wrote: > > > > The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This > > causes warnings with newer kernels. > > > > Prepare the gpio-tqmx86 driver for the fixed MFD

Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Andy Shevchenko
On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer wrote: > > The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This > causes warnings with newer kernels. > > Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a > missing IRQ properly. Also you missed a Fixes tag.

Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Andy Shevchenko
On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer wrote: > > The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This > causes warnings with newer kernels. > > Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a > missing IRQ properly. ... > - irq =

[PATCH 1/3] gpio: tqmx86: really make IRQ optional

2021-03-31 Thread Matthias Schiffer
The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This causes warnings with newer kernels. Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a missing IRQ properly. Signed-off-by: Matthias Schiffer --- drivers/gpio/gpio-tqmx86.c | 6 +++--- 1 file changed, 3