Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-03-03 Thread Marek Vasut
On Monday, March 03, 2014 at 11:23:33 AM, Yao Yuan wrote: > Hi, Marek > > Marek Vasut wrote: > > On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: > > > > [...] > > > > > +static void i2c_imx_dma_free(struct imx_i2c_struct *i2c_imx) { > > > + struct imx_i2c_dma *dma = i2c_imx->dma;

RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-03-03 Thread Yao Yuan
Hi, Marek Marek Vasut wrote: > On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: > > [...] > > > +static void i2c_imx_dma_free(struct imx_i2c_struct *i2c_imx) { > > + struct imx_i2c_dma *dma = i2c_imx->dma; > > + struct dma_chan *dma_chan; > > + > > + dma_chan = dma->chan_tx;

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 11:59:25 AM, Lothar Waßmann wrote: > Hi, > > Marek Vasut wrote: > > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > > > [...] > > > > > Yes, here have two dma channels, one for RX and the other one for TX. > > > When we request the channel we shou

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 12:36:01 PM, Yao Yuan wrote: > Hi Marek, > > > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > > > [...] > > > > > > > @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata > > > > > = { > > > > > > > > > > .ndivs

RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Yao Yuan
Hi Marek, > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > [...] > > > > > @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata > > > > = { > > > > > > > > .ndivs = ARRAY_SIZE(vf610_i2c_clk_div), > > > > .i2sr_clr_opcode= I2S

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Lothar Waßmann
Hi, Marek Vasut wrote: > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > [...] > > Yes, here have two dma channels, one for RX and the other one for TX. > > When we request the channel we should determine it for TX or RX. > > Sorry, I don't quite understand this. If you have two

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 03:23:52 AM, Shawn Guo wrote: > On Fri, Feb 28, 2014 at 10:13:02AM +0800, Shawn Guo wrote: > > On Thu, Feb 27, 2014 at 09:39:35PM +0100, Marek Vasut wrote: > > > > @@ -193,6 +216,7 @@ static const struct imx_i2c_hwdata > > > > imx1_i2c_hwdata = { > > > > > > > >

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: [...] > > > @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = { > > > > > > .ndivs = ARRAY_SIZE(vf610_i2c_clk_div), > > > .i2sr_clr_opcode= I2SR_CLR_OPCODE_W1C, > > > .i2cr_ien_opcode

RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Yao Yuan
awn@linaro.org; linux-kernel@vger.kernel.org; linux- > i...@vger.kernel.org > Subject: Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver > > On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: > > [...] > > > */ @@ -63,6 +68,9 @@ > >

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Shawn Guo
On Fri, Feb 28, 2014 at 10:13:02AM +0800, Shawn Guo wrote: > On Thu, Feb 27, 2014 at 09:39:35PM +0100, Marek Vasut wrote: > > > @@ -193,6 +216,7 @@ static const struct imx_i2c_hwdata imx1_i2c_hwdata = > > > { > > > .ndivs = ARRAY_SIZE(imx_i2c_clk_div), > > > .i2sr_clr_opcode

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Shawn Guo
On Thu, Feb 27, 2014 at 09:39:35PM +0100, Marek Vasut wrote: > > @@ -193,6 +216,7 @@ static const struct imx_i2c_hwdata imx1_i2c_hwdata = { > > .ndivs = ARRAY_SIZE(imx_i2c_clk_div), > > .i2sr_clr_opcode= I2SR_CLR_OPCODE_W0C, > > .i2cr_ien_opcode= I2CR_I

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Marek Vasut
On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: [...] > */ @@ -63,6 +68,9 @@ > /* Default value */ > #define IMX_I2C_BIT_RATE 10 /* 100kHz */ > > +/* enable DMA if transfer size is bigger than this threshold */ > +#define IMX_I2C_DMA_THRESHOLD16 So what's t

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Shawn Guo
On Thu, Feb 27, 2014 at 08:55:45PM +0800, Shawn Guo wrote: > On Thu, Feb 27, 2014 at 02:05:14PM +0800, Yuan Yao wrote: > > Add dma support for i2c. This function depend on DMA driver. > > You can turn on it by write both the dmas and dma-name properties in dts > > node. > > And you should set ".ha

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Shawn Guo
On Thu, Feb 27, 2014 at 02:05:14PM +0800, Yuan Yao wrote: > Add dma support for i2c. This function depend on DMA driver. > You can turn on it by write both the dmas and dma-name properties in dts node. > And you should set ".has_dma_support" as true for dma support in > imx_i2c_hwdata struct. > >

[PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-26 Thread Yuan Yao
Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. And you should set ".has_dma_support" as true for dma support in imx_i2c_hwdata struct. Signed-off-by: Yuan Yao --- drivers/i2c/busses/i2c-imx.c | 358