Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-05-02 Thread Daniel Walker
On Wed, 2007-05-02 at 10:58 -0700, john stultz wrote: > On Fri, 2007-04-27 at 12:11 -0400, Peter Keilty wrote: > > Daniel Walker wrote: > > >On Fri, 2007-04-27 at 11:42 -0400, Peter Keilty wrote: > > >>>There is a read(), and a vread() did you modify the slow syscall path to > > >>>use the vread()?

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-05-02 Thread john stultz
On Fri, 2007-04-27 at 12:11 -0400, Peter Keilty wrote: > Daniel Walker wrote: > >On Fri, 2007-04-27 at 11:42 -0400, Peter Keilty wrote: > >>>There is a read(), and a vread() did you modify the slow syscall path to > >>>use the vread()? > >>> > >John mentioned that he thought fsys_mmio_ptr could be

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-05-02 Thread john stultz
On Fri, 2007-04-27 at 08:54 -0400, Peter Keilty wrote: > john stultz wrote: > >On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: > >>From: Peter Keilty <[EMAIL PROTECTED]> > >> > >>Initial ia64 conversion to the generic timekeeping/clocksource code. > >> > >>Signed-off-by: Peter Keilty <[EMAIL

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Daniel Walker
On Fri, 2007-04-27 at 12:11 -0400, Peter Keilty wrote: > > > No, but yes it can be done, overloading the meaning. > It would need to change in the future if vread was needed. > I have no strong argument against using it. > Although we may still need the IA64 define, I removed 32bit read mmio and

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Peter Keilty
Daniel Walker wrote: On Fri, 2007-04-27 at 11:42 -0400, Peter Keilty wrote: There is a read(), and a vread() did you modify the slow syscall path to use the vread()? I miss type, read(). John mentioned that he thought fsys_mmio_ptr could be held in the vread pointer. vread(

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Daniel Walker
On Fri, 2007-04-27 at 11:42 -0400, Peter Keilty wrote: > > > >There is a read(), and a vread() did you modify the slow syscall path to > >use the vread()? > > > > > I miss type, read(). John mentioned that he thought fsys_mmio_ptr could be held in the vread pointer. vread() is used in x86 for v

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Peter Keilty
Daniel Walker wrote: On Fri, 2007-04-27 at 10:38 -0400, Peter Keilty wrote: Daniel Walker wrote: On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: +.mask = (1LL << 40) - 1, +.mult = 0, /*to be caluclated*/ +.shift =

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Daniel Walker
On Fri, 2007-04-27 at 10:38 -0400, Peter Keilty wrote: > Daniel Walker wrote: > > >On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: > > > > > > > >>+.mask = (1LL << 40) - 1, > >>+.mult = 0, /*to be caluclated*/ > >>+.shift = 16, > >>+

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Peter Keilty
Daniel Walker wrote: On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: +.mask = (1LL << 40) - 1, +.mult = 0, /*to be caluclated*/ +.shift = 16, +.is_continuous = 1, }; You should use CLOCKSOURCE_MASK() here .. It

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Peter Keilty
Chris Wright wrote: * Peter Keilty ([EMAIL PROTECTED]) wrote: diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 6077300..35ad71f 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -480,10 +480,12 @@ #endif /* Get e

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Peter Keilty
john stultz wrote: On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: From: Peter Keilty <[EMAIL PROTECTED]> Initial ia64 conversion to the generic timekeeping/clocksource code. Signed-off-by: Peter Keilty <[EMAIL PROTECTED]> Signed-off-by: John Stultz <[EMAIL PROTECTED]> Peter,

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-26 Thread Chris Wright
* Peter Keilty ([EMAIL PROTECTED]) wrote: > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > index 6077300..35ad71f 100644 > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -480,10 +480,12 @@ #endif > /* Get end time (ticks) *

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-26 Thread john stultz
On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: > From: Peter Keilty <[EMAIL PROTECTED]> > > Initial ia64 conversion to the generic timekeeping/clocksource code. > > Signed-off-by: Peter Keilty <[EMAIL PROTECTED]> > Signed-off-by: John Stultz <[EMAIL PROTECTED]> Peter, Thanks so m

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-26 Thread Daniel Walker
On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: > +.mask = (1LL << 40) - 1, > +.mult = 0, /*to be caluclated*/ > +.shift = 16, > +.is_continuous = 1, > }; You should use CLOCKSOURCE_MASK() here .. > > diff --git a/include/l

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-26 Thread john stultz
On Thu, 2007-04-26 at 22:41 +0200, Sam Ravnborg wrote: > On Thu, Apr 26, 2007 at 04:26:32PM -0400, Peter Keilty wrote: > > From: Peter Keilty <[EMAIL PROTECTED]> > > > > Initial ia64 conversion to the generic timekeeping/clocksource code. > > > > Signed-off-by: Peter Keilty <[EMAIL PROTECTED]> >

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-26 Thread Sam Ravnborg
On Thu, Apr 26, 2007 at 04:26:32PM -0400, Peter Keilty wrote: > From: Peter Keilty <[EMAIL PROTECTED]> > > Initial ia64 conversion to the generic timekeeping/clocksource code. > > Signed-off-by: Peter Keilty <[EMAIL PROTECTED]> > Signed-off-by: John Stultz <[EMAIL PROTECTED]> The "Signed-off-by:

[PATCH 1/3] ia64: convert to use clocksource code

2007-04-26 Thread Peter Keilty
From: Peter Keilty <[EMAIL PROTECTED]> Initial ia64 conversion to the generic timekeeping/clocksource code. Signed-off-by: Peter Keilty <[EMAIL PROTECTED]> Signed-off-by: John Stultz <[EMAIL PROTECTED]> --- arch/ia64/Kconfig |6 +- arch/ia64/configs/bigsur_defconfig