Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-21 Thread Jonathan Cameron
On Mon, 18 May 2020 08:07:21 + "Ardelean, Alexandru" wrote: > On Sat, 2020-05-16 at 17:29 +0100, Jonathan Cameron wrote: > > [External] > > > > On Tue, 12 May 2020 11:26:08 + > > "Ardelean, Alexandru" wrote: > > > > > On Mon, 2020-05-11 at 18:42 +0100, Jonathan Cameron wrote: > >

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-18 Thread Ardelean, Alexandru
On Sat, 2020-05-16 at 17:29 +0100, Jonathan Cameron wrote: > [External] > > On Tue, 12 May 2020 11:26:08 + > "Ardelean, Alexandru" wrote: > > > On Mon, 2020-05-11 at 18:42 +0100, Jonathan Cameron wrote: > > > [External] > > > > > > On Mon, 11 May 2020 09:16:32 + > > > "Ardelean,

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-16 Thread Jonathan Cameron
On Tue, 12 May 2020 11:26:08 + "Ardelean, Alexandru" wrote: > On Mon, 2020-05-11 at 18:42 +0100, Jonathan Cameron wrote: > > [External] > > > > On Mon, 11 May 2020 09:16:32 + > > "Ardelean, Alexandru" wrote: > > > > > On Fri, 2020-05-08 at 16:44 +0100, Jonathan Cameron wrote: > >

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-12 Thread Ardelean, Alexandru
On Mon, 2020-05-11 at 18:42 +0100, Jonathan Cameron wrote: > [External] > > On Mon, 11 May 2020 09:16:32 + > "Ardelean, Alexandru" wrote: > > > On Fri, 2020-05-08 at 16:44 +0100, Jonathan Cameron wrote: > > > [External] > > > > > > On Fri, 8 May 2020 16:40:15 +0100 > > > Jonathan Cameron

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-11 Thread Jonathan Cameron
On Mon, 11 May 2020 09:16:32 + "Ardelean, Alexandru" wrote: > On Fri, 2020-05-08 at 16:44 +0100, Jonathan Cameron wrote: > > [External] > > > > On Fri, 8 May 2020 16:40:15 +0100 > > Jonathan Cameron wrote: > > > > > On Fri, 8 May 2020 17:13:04 +0300 > > > Alexandru Ardelean wrote: > >

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-11 Thread Ardelean, Alexandru
On Fri, 2020-05-08 at 16:44 +0100, Jonathan Cameron wrote: > [External] > > On Fri, 8 May 2020 16:40:15 +0100 > Jonathan Cameron wrote: > > > On Fri, 8 May 2020 17:13:04 +0300 > > Alexandru Ardelean wrote: > > > > > There are plenty of bad designs we want to discourage or not have to > > >

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-08 Thread Jonathan Cameron
On Fri, 8 May 2020 16:40:15 +0100 Jonathan Cameron wrote: > On Fri, 8 May 2020 17:13:04 +0300 > Alexandru Ardelean wrote: > > > There are plenty of bad designs we want to discourage or not have to review > > manually usually about accessing private (marked as [INTERN]) fields of > > 'struct

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-08 Thread Jonathan Cameron
On Fri, 8 May 2020 17:13:04 +0300 Alexandru Ardelean wrote: > There are plenty of bad designs we want to discourage or not have to review > manually usually about accessing private (marked as [INTERN]) fields of > 'struct iio_dev'. This has been on the todo list for many years so great you are

[PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-08 Thread Alexandru Ardelean
There are plenty of bad designs we want to discourage or not have to review manually usually about accessing private (marked as [INTERN]) fields of 'struct iio_dev'. This is difficult, as a lot of users copy drivers, and not always the best examples. A better idea is to hide those fields into