Re: [PATCH 1/3] input: do not use tasklet_disable before tasklet_kill

2012-11-24 Thread Dmitry Torokhov
Hi Xiaotian, On Wed, Oct 31, 2012 at 04:05:59PM +0800, Xiaotian Feng wrote: > If tasklet_disable() is called before related tasklet handled, > tasklet_kill will never be finished. tasklet_kill is enough. > Could you please elaborate on this? Needing to disable tasket before killing it is quite

Re: [PATCH 1/3] input: do not use tasklet_disable before tasklet_kill

2012-11-24 Thread Dmitry Torokhov
Hi Xiaotian, On Wed, Oct 31, 2012 at 04:05:59PM +0800, Xiaotian Feng wrote: If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Could you please elaborate on this? Needing to disable tasket before killing it is quite

[PATCH 1/3] input: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Xiaotian Feng
If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng Cc: Dmitry Torokhov Cc: Tony Lindgren Cc: Sourav Poddar Cc: Josh Cc: Greg Kroah-Hartman Cc: linux-in...@vger.kernel.org ---

[PATCH 1/3] input: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Xiaotian Feng
If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: Tony Lindgren t...@atomide.com Cc: Sourav Poddar sourav.pod...@ti.com