Re: [PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

Hi, On Tue, Nov 24, 2020 at 9:42 AM Maulik Shah wrote: > > Hi Linus, > > +* When we change types the PDC can give a phantom interrupt. > +* Clear it. Specifically the phantom shows up if a line is already > +* high and we change to rising or if a line is already low and w

Re: [PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

Hi Linus, +* When we change types the PDC can give a phantom interrupt. +* Clear it. Specifically the phantom shows up if a line is already +* high and we change to rising or if a line is already low and we +* change to falling but let's be consistent and clear it

Re: [PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

Hi, On Tue, Nov 24, 2020 at 1:00 AM Marc Zyngier wrote: > > > @@ -187,9 +189,24 @@ static int qcom_pdc_gic_set_type(struct irq_data > > *d, unsigned int type) > > return -EINVAL; > > } > > > > + old_pdc_type = pdc_reg_read(IRQ_i_CFG, pin_out); > > pdc_reg_write(IRQ_i

Re: [PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

Hi, On Tue, Nov 24, 2020 at 12:28 AM Linus Walleij wrote: > > On Tue, Nov 24, 2020 at 1:02 AM Douglas Anderson > wrote: > > > We have a problem if we use gpio-keys and configure wakeups such that > > we only want one edge to wake us up. AKA: > > wakeup-event-action = ; > > wakeup-source; >

Re: [PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

On 2020-11-24 00:01, Douglas Anderson wrote: We have a problem if we use gpio-keys and configure wakeups such that we only want one edge to wake us up. AKA: wakeup-event-action = ; wakeup-source; Specifically we end up with a phantom interrupt that blocks suspend if the line was already hig

Re: [PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

On Tue, Nov 24, 2020 at 1:02 AM Douglas Anderson wrote: > We have a problem if we use gpio-keys and configure wakeups such that > we only want one edge to wake us up. AKA: > wakeup-event-action = ; > wakeup-source; I would need Marc's ACK to apply this with the other patches to the pinctrl

Re: [PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

Hi Doug, Thanks for the patch. Looks good to me and tested. Reviewed-by: Maulik Shah Tested-by: Maulik Shah Thanks, Maulik On 11/24/2020 5:31 AM, Douglas Anderson wrote: We have a problem if we use gpio-keys and configure wakeups such that we only want one edge to wake us up. AKA: wakeu

[PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

We have a problem if we use gpio-keys and configure wakeups such that we only want one edge to wake us up. AKA: wakeup-event-action = ; wakeup-source; Specifically we end up with a phantom interrupt that blocks suspend if the line was already high and we want wakeups on rising edges (AKA we w