Re: [PATCH 1/3] kcov: remove #ifdef CONFIG_RANDOMIZE_BASE

2017-09-29 Thread Andrey Ryabinin
On 09/19/2017 04:47 PM, Dmitry Vyukov wrote: > On Tue, Sep 19, 2017 at 3:30 PM, Mark Rutland wrote: >> Hi, >> >> On Tue, Sep 19, 2017 at 03:46:46PM +0300, Andrey Ryabinin wrote: >>> There is no need to surround kaslr_offset() with CONFIG_RANDOMIZE_BASE >>> ifdef. >>> kaslr_offset() will just retu

Re: [PATCH 1/3] kcov: remove #ifdef CONFIG_RANDOMIZE_BASE

2017-09-21 Thread kbuild test robot
Hi Andrey, [auto build test ERROR on linus/master] [also build test ERROR on v4.14-rc1 next-20170921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andrey-Ryabinin/kcov-remove-ifdef-CONFIG_RAND

Re: [PATCH 1/3] kcov: remove #ifdef CONFIG_RANDOMIZE_BASE

2017-09-19 Thread Dmitry Vyukov
On Tue, Sep 19, 2017 at 3:30 PM, Mark Rutland wrote: > Hi, > > On Tue, Sep 19, 2017 at 03:46:46PM +0300, Andrey Ryabinin wrote: >> There is no need to surround kaslr_offset() with CONFIG_RANDOMIZE_BASE ifdef. >> kaslr_offset() will just return 0 if CONFIG_RANDOMIZE_BASE isn't set. >> >> Signed-off

Re: [PATCH 1/3] kcov: remove #ifdef CONFIG_RANDOMIZE_BASE

2017-09-19 Thread Mark Rutland
Hi, On Tue, Sep 19, 2017 at 03:46:46PM +0300, Andrey Ryabinin wrote: > There is no need to surround kaslr_offset() with CONFIG_RANDOMIZE_BASE ifdef. > kaslr_offset() will just return 0 if CONFIG_RANDOMIZE_BASE isn't set. > > Signed-off-by: Andrey Ryabinin > --- > kernel/kcov.c | 2 -- > 1 file

Re: [PATCH 1/3] kcov: remove #ifdef CONFIG_RANDOMIZE_BASE

2017-09-19 Thread Dmitry Vyukov
On Tue, Sep 19, 2017 at 2:46 PM, Andrey Ryabinin wrote: > There is no need to surround kaslr_offset() with CONFIG_RANDOMIZE_BASE ifdef. > kaslr_offset() will just return 0 if CONFIG_RANDOMIZE_BASE isn't set. > > Signed-off-by: Andrey Ryabinin As you said this is a very hot function, but this ch

[PATCH 1/3] kcov: remove #ifdef CONFIG_RANDOMIZE_BASE

2017-09-19 Thread Andrey Ryabinin
There is no need to surround kaslr_offset() with CONFIG_RANDOMIZE_BASE ifdef. kaslr_offset() will just return 0 if CONFIG_RANDOMIZE_BASE isn't set. Signed-off-by: Andrey Ryabinin --- kernel/kcov.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/kcov.c b/kernel/kcov.c index 3f693a0f6f