Re: [PATCH 1/3] make queue_delayed_work() friendly to flush_fork()

2007-02-11 Thread Oleg Nesterov
On 02/11, Oleg Nesterov wrote: > > This makes impossible to use flush_fork(delayed_work->work) in addition > to cancel_delayed_work/cancel_rearming_delayed_work, not good. It turns out this patch is in fact bug-fix. I didn't notice that we already have flush_fork(delayed_work) calls! This

Re: [PATCH 1/3] make queue_delayed_work() friendly to flush_fork()

2007-02-11 Thread Oleg Nesterov
On 02/11, Oleg Nesterov wrote: This makes impossible to use flush_fork(delayed_work-work) in addition to cancel_delayed_work/cancel_rearming_delayed_work, not good. It turns out this patch is in fact bug-fix. I didn't notice that we already have flush_fork(delayed_work) calls! This means

[PATCH 1/3] make queue_delayed_work() friendly to flush_fork()

2007-02-10 Thread Oleg Nesterov
Currently typeof(delayed_work->work.data) is "struct workqueue_struct" when the timer is pending "struct cpu_workqueue_struct" whe the work is queued This makes impossible to use flush_fork(delayed_work->work) in addition to cancel_delayed_work/cancel_rearming_delayed_work, not

[PATCH 1/3] make queue_delayed_work() friendly to flush_fork()

2007-02-10 Thread Oleg Nesterov
Currently typeof(delayed_work-work.data) is struct workqueue_struct when the timer is pending struct cpu_workqueue_struct whe the work is queued This makes impossible to use flush_fork(delayed_work-work) in addition to cancel_delayed_work/cancel_rearming_delayed_work, not good.