Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Weidong Wang
On 2015/10/27 18:33, Kashyap Desai wrote: >>> + dev_dbg(>pdev->dev, "Error copying out >>> cmd_status\n"); >>> error = -EFAULT; >>> } >>> >> >> Reviewed-by: Johannes Thumshirn > > We will consider all three patches for future submission. As of now we have > two patch

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Weidong Wang
On 2015/10/28 3:35, Joe Perches wrote: > On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote: >> Reduce object size a little by using dev_ >> calls instead of dev_printk(KERN_. > > This is also not the same output. > > dev_printk(KERN_DEBUG vs dev_dbg has the same > behavior as

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Joe Perches
On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote: > Reduce object size a little by using dev_ > calls instead of dev_printk(KERN_. This is also not the same output. dev_printk(KERN_DEBUG vs dev_dbg has the same behavior as printk(KERN_DEBUG vs pr_debug > diff --git

RE: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Kashyap Desai
> > + dev_dbg(>pdev->dev, "Error copying out > > cmd_status\n"); > > error = -EFAULT; > > } > > > > Reviewed-by: Johannes Thumshirn We will consider all three patches for future submission. As of now we have two patch set pending to be committed. We are working for few

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Johannes Thumshirn
On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote: > Reduce object size a little by using dev_ > calls instead of dev_printk(KERN_. > > Signed-off-by: Weidong Wang > --- >  drivers/scsi/megaraid/megaraid_sas_base.c | 68 +++ > >  1 file changed, 34 insertions(+),

[PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Weidong Wang
Reduce object size a little by using dev_ calls instead of dev_printk(KERN_. Signed-off-by: Weidong Wang --- drivers/scsi/megaraid/megaraid_sas_base.c | 68 +++ 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Weidong Wang
Reduce object size a little by using dev_ calls instead of dev_printk(KERN_. Signed-off-by: Weidong Wang --- drivers/scsi/megaraid/megaraid_sas_base.c | 68 +++ 1 file changed, 34 insertions(+), 34 deletions(-) diff --git

RE: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Kashyap Desai
> > + dev_dbg(>pdev->dev, "Error copying out > > cmd_status\n"); > > error = -EFAULT; > > } > > > > Reviewed-by: Johannes Thumshirn We will consider all three patches for future submission. As of now we have two patch set pending to be committed. We

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Johannes Thumshirn
On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote: > Reduce object size a little by using dev_ > calls instead of dev_printk(KERN_. > > Signed-off-by: Weidong Wang > --- >  drivers/scsi/megaraid/megaraid_sas_base.c | 68 +++ > >  1 file

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Joe Perches
On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote: > Reduce object size a little by using dev_ > calls instead of dev_printk(KERN_. This is also not the same output. dev_printk(KERN_DEBUG vs dev_dbg has the same behavior as printk(KERN_DEBUG vs pr_debug > diff --git

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Weidong Wang
On 2015/10/28 3:35, Joe Perches wrote: > On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote: >> Reduce object size a little by using dev_ >> calls instead of dev_printk(KERN_. > > This is also not the same output. > > dev_printk(KERN_DEBUG vs dev_dbg has the same > behavior as

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Weidong Wang
On 2015/10/27 18:33, Kashyap Desai wrote: >>> + dev_dbg(>pdev->dev, "Error copying out >>> cmd_status\n"); >>> error = -EFAULT; >>> } >>> >> >> Reviewed-by: Johannes Thumshirn > > We will consider all three patches for future submission. As of now we