Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-07-03 Thread Guenter Roeck
On 07/03/2016 09:49 AM, Lars-Peter Clausen wrote: On 07/03/2016 01:17 PM, Jonathan Cameron wrote: On 28/06/16 09:18, Quentin Schulz wrote: The Allwinner SoCs all have an ADC that can also act as a touchscreen controller and a thermal sensor. For now, only the ADC and the thermal sensor drivers

Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-07-03 Thread Guenter Roeck
On 07/03/2016 09:49 AM, Lars-Peter Clausen wrote: On 07/03/2016 01:17 PM, Jonathan Cameron wrote: On 28/06/16 09:18, Quentin Schulz wrote: The Allwinner SoCs all have an ADC that can also act as a touchscreen controller and a thermal sensor. For now, only the ADC and the thermal sensor drivers

Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-07-03 Thread Lars-Peter Clausen
On 07/03/2016 01:17 PM, Jonathan Cameron wrote: > On 28/06/16 09:18, Quentin Schulz wrote: >> The Allwinner SoCs all have an ADC that can also act as a touchscreen >> controller and a thermal sensor. For now, only the ADC and the thermal >> sensor drivers are probed by the MFD, the touchscreen

Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-07-03 Thread Lars-Peter Clausen
On 07/03/2016 01:17 PM, Jonathan Cameron wrote: > On 28/06/16 09:18, Quentin Schulz wrote: >> The Allwinner SoCs all have an ADC that can also act as a touchscreen >> controller and a thermal sensor. For now, only the ADC and the thermal >> sensor drivers are probed by the MFD, the touchscreen

Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-07-03 Thread Jonathan Cameron
On 28/06/16 09:18, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. For now, only the ADC and the thermal > sensor drivers are probed by the MFD, the touchscreen controller support > will be added later. > >

Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-07-03 Thread Jonathan Cameron
On 28/06/16 09:18, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. For now, only the ADC and the thermal > sensor drivers are probed by the MFD, the touchscreen controller support > will be added later. > >

Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-06-28 Thread Antoine Tenart
Hello, On Tue, Jun 28, 2016 at 10:18:15AM +0200, Quentin Schulz wrote: > diff --git a/drivers/mfd/sunxi-gpadc-mfd.c b/drivers/mfd/sunxi-gpadc-mfd.c > new file mode 100644 > index 000..710e297 > --- /dev/null > +++ b/drivers/mfd/sunxi-gpadc-mfd.c > @@ -0,0 +1,188 @@ [...] > + if

Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-06-28 Thread Antoine Tenart
Hello, On Tue, Jun 28, 2016 at 10:18:15AM +0200, Quentin Schulz wrote: > diff --git a/drivers/mfd/sunxi-gpadc-mfd.c b/drivers/mfd/sunxi-gpadc-mfd.c > new file mode 100644 > index 000..710e297 > --- /dev/null > +++ b/drivers/mfd/sunxi-gpadc-mfd.c > @@ -0,0 +1,188 @@ [...] > + if

Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-06-28 Thread Antoine Tenart
Hello Quentin! A few comments bellow: On Tue, Jun 28, 2016 at 10:18:15AM +0200, Quentin Schulz wrote: > > diff --git a/drivers/mfd/sunxi-gpadc-mfd.c b/drivers/mfd/sunxi-gpadc-mfd.c > new file mode 100644 > index 000..710e297 > --- /dev/null > +++ b/drivers/mfd/sunxi-gpadc-mfd.c > @@ -0,0

Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-06-28 Thread Antoine Tenart
Hello Quentin! A few comments bellow: On Tue, Jun 28, 2016 at 10:18:15AM +0200, Quentin Schulz wrote: > > diff --git a/drivers/mfd/sunxi-gpadc-mfd.c b/drivers/mfd/sunxi-gpadc-mfd.c > new file mode 100644 > index 000..710e297 > --- /dev/null > +++ b/drivers/mfd/sunxi-gpadc-mfd.c > @@ -0,0

[PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-06-28 Thread Quentin Schulz
The Allwinner SoCs all have an ADC that can also act as a touchscreen controller and a thermal sensor. For now, only the ADC and the thermal sensor drivers are probed by the MFD, the touchscreen controller support will be added later. Signed-off-by: Quentin Schulz

[PATCH 1/3] mfd: add support for Allwinner SoCs ADC

2016-06-28 Thread Quentin Schulz
The Allwinner SoCs all have an ADC that can also act as a touchscreen controller and a thermal sensor. For now, only the ADC and the thermal sensor drivers are probed by the MFD, the touchscreen controller support will be added later. Signed-off-by: Quentin Schulz --- drivers/mfd/Kconfig