Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-19 Thread Lee Jones
On Tue, 11 Nov 2014, Richard Fitzgerald wrote: > Signed-off-by: Richard Fitzgerald > --- > drivers/mfd/Kconfig |6 + > drivers/mfd/Makefile |3 + > drivers/mfd/arizona-core.c | 91 ++- > drivers/mfd/arizona-irq.c| 42 +- >

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-19 Thread Lee Jones
On Tue, 11 Nov 2014, Richard Fitzgerald wrote: Signed-off-by: Richard Fitzgerald r...@opensource.wolfsonmicro.com --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile |3 + drivers/mfd/arizona-core.c | 91 ++- drivers/mfd/arizona-irq.c| 42

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-18 Thread Mark Brown
On Mon, Nov 17, 2014 at 03:13:18PM +, Charles Keepax wrote: > 1) We could add #defines for various IP blocks and the readable > callback could include these defines for various blocks. Which > would reduce the duplication between chips. Although a lot of the > blocks have small differences

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-18 Thread Richard Fitzgerald
On Tue, Nov 18, 2014 at 11:34:01AM +, Lee Jones wrote: > On Mon, 17 Nov 2014, Mark Brown wrote: > > > On Mon, Nov 17, 2014 at 12:54:33PM +, Richard Fitzgerald wrote: > > > On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: > > > > > > Looks like I was a little hasty with my

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-18 Thread Lee Jones
On Mon, 17 Nov 2014, Mark Brown wrote: > On Mon, Nov 17, 2014 at 12:54:33PM +, Richard Fitzgerald wrote: > > On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: > > > > Looks like I was a little hasty with my comments. However 8000 lines > > > over 4 platforms just to describe which

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-18 Thread Mark Brown
On Mon, Nov 17, 2014 at 03:13:18PM +, Charles Keepax wrote: 1) We could add #defines for various IP blocks and the readable callback could include these defines for various blocks. Which would reduce the duplication between chips. Although a lot of the blocks have small differences

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-18 Thread Lee Jones
On Mon, 17 Nov 2014, Mark Brown wrote: On Mon, Nov 17, 2014 at 12:54:33PM +, Richard Fitzgerald wrote: On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: Looks like I was a little hasty with my comments. However 8000 lines over 4 platforms just to describe which registers

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-18 Thread Richard Fitzgerald
On Tue, Nov 18, 2014 at 11:34:01AM +, Lee Jones wrote: On Mon, 17 Nov 2014, Mark Brown wrote: On Mon, Nov 17, 2014 at 12:54:33PM +, Richard Fitzgerald wrote: On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: Looks like I was a little hasty with my comments. However

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-17 Thread Mark Brown
On Mon, Nov 17, 2014 at 12:54:33PM +, Richard Fitzgerald wrote: > On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: > > Looks like I was a little hasty with my comments. However 8000 lines > > over 4 platforms just to describe which registers are readable is all > > a little bit

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-17 Thread Charles Keepax
On Mon, Nov 17, 2014 at 12:54:33PM +, Richard Fitzgerald wrote: > On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: > > On Thu, 13 Nov 2014, Charles Keepax wrote: > > > This looks good to me. I don't quite follow what you are > > > requesting with the header file? This still uses the

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-17 Thread Richard Fitzgerald
On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: > On Thu, 13 Nov 2014, Charles Keepax wrote: > > > On Thu, Nov 13, 2014 at 10:12:28AM +, Lee Jones wrote: > > > On Tue, 11 Nov 2014, Richard Fitzgerald wrote: > > > > > > > Signed-off-by: Richard Fitzgerald > > > > --- > > > >

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-17 Thread Lee Jones
On Thu, 13 Nov 2014, Charles Keepax wrote: > On Thu, Nov 13, 2014 at 10:12:28AM +, Lee Jones wrote: > > On Tue, 11 Nov 2014, Richard Fitzgerald wrote: > > > > > Signed-off-by: Richard Fitzgerald > > > --- > > > drivers/mfd/Kconfig |6 + > > > drivers/mfd/Makefile

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-17 Thread Lee Jones
On Thu, 13 Nov 2014, Charles Keepax wrote: On Thu, Nov 13, 2014 at 10:12:28AM +, Lee Jones wrote: On Tue, 11 Nov 2014, Richard Fitzgerald wrote: Signed-off-by: Richard Fitzgerald r...@opensource.wolfsonmicro.com --- drivers/mfd/Kconfig |6 +

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-17 Thread Richard Fitzgerald
On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: On Thu, 13 Nov 2014, Charles Keepax wrote: On Thu, Nov 13, 2014 at 10:12:28AM +, Lee Jones wrote: On Tue, 11 Nov 2014, Richard Fitzgerald wrote: Signed-off-by: Richard Fitzgerald r...@opensource.wolfsonmicro.com ---

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-17 Thread Charles Keepax
On Mon, Nov 17, 2014 at 12:54:33PM +, Richard Fitzgerald wrote: On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: On Thu, 13 Nov 2014, Charles Keepax wrote: This looks good to me. I don't quite follow what you are requesting with the header file? This still uses the header

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-17 Thread Mark Brown
On Mon, Nov 17, 2014 at 12:54:33PM +, Richard Fitzgerald wrote: On Mon, Nov 17, 2014 at 12:16:48PM +, Lee Jones wrote: Looks like I was a little hasty with my comments. However 8000 lines over 4 platforms just to describe which registers are readable is all a little bit grim. Is

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-13 Thread Charles Keepax
On Thu, Nov 13, 2014 at 10:12:28AM +, Lee Jones wrote: > On Tue, 11 Nov 2014, Richard Fitzgerald wrote: > > > Signed-off-by: Richard Fitzgerald > > --- > > drivers/mfd/Kconfig |6 + > > drivers/mfd/Makefile |3 + > > drivers/mfd/arizona-core.c | 91

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-13 Thread Richard Fitzgerald
On Thu, Nov 13, 2014 at 10:12:28AM +, Lee Jones wrote: > On Tue, 11 Nov 2014, Richard Fitzgerald wrote: > > > Signed-off-by: Richard Fitzgerald > > --- > > drivers/mfd/Kconfig |6 + > > drivers/mfd/Makefile |3 + > > drivers/mfd/arizona-core.c | 91

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-13 Thread Lee Jones
On Tue, 11 Nov 2014, Richard Fitzgerald wrote: > Signed-off-by: Richard Fitzgerald > --- > drivers/mfd/Kconfig |6 + > drivers/mfd/Makefile |3 + > drivers/mfd/arizona-core.c | 91 ++- > drivers/mfd/arizona-irq.c| 42 +- >

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-13 Thread Lee Jones
On Tue, 11 Nov 2014, Richard Fitzgerald wrote: Signed-off-by: Richard Fitzgerald r...@opensource.wolfsonmicro.com --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile |3 + drivers/mfd/arizona-core.c | 91 ++- drivers/mfd/arizona-irq.c| 42

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-13 Thread Richard Fitzgerald
On Thu, Nov 13, 2014 at 10:12:28AM +, Lee Jones wrote: On Tue, 11 Nov 2014, Richard Fitzgerald wrote: Signed-off-by: Richard Fitzgerald r...@opensource.wolfsonmicro.com --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile |3 +

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-13 Thread Charles Keepax
On Thu, Nov 13, 2014 at 10:12:28AM +, Lee Jones wrote: On Tue, 11 Nov 2014, Richard Fitzgerald wrote: Signed-off-by: Richard Fitzgerald r...@opensource.wolfsonmicro.com --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile |3 +

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-12 Thread Charles Keepax
On Tue, Nov 11, 2014 at 05:03:19PM +, Richard Fitzgerald wrote: > Signed-off-by: Richard Fitzgerald > --- > drivers/mfd/Kconfig |6 + > drivers/mfd/Makefile |3 + > drivers/mfd/arizona-core.c | 91 ++- > drivers/mfd/arizona-irq.c| 42 +- >

Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-12 Thread Charles Keepax
On Tue, Nov 11, 2014 at 05:03:19PM +, Richard Fitzgerald wrote: Signed-off-by: Richard Fitzgerald r...@opensource.wolfsonmicro.com --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile |3 + drivers/mfd/arizona-core.c | 91 ++-

[PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-11 Thread Richard Fitzgerald
Signed-off-by: Richard Fitzgerald --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile |3 + drivers/mfd/arizona-core.c | 91 ++- drivers/mfd/arizona-irq.c| 42 +- drivers/mfd/arizona-spi.c|9 + drivers/mfd/arizona.h|5

[PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-11 Thread Richard Fitzgerald
Signed-off-by: Richard Fitzgerald --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile |3 + drivers/mfd/arizona-core.c | 91 ++- drivers/mfd/arizona-irq.c| 42 +- drivers/mfd/arizona-spi.c|9 + drivers/mfd/arizona.h|5

[PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-11 Thread Richard Fitzgerald
Signed-off-by: Richard Fitzgerald r...@opensource.wolfsonmicro.com --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile |3 + drivers/mfd/arizona-core.c | 91 ++- drivers/mfd/arizona-irq.c| 42 +- drivers/mfd/arizona-spi.c|9 +

[PATCH 1/3] mfd: arizona: Add support for CS47L24

2014-11-11 Thread Richard Fitzgerald
Signed-off-by: Richard Fitzgerald r...@opensource.wolfsonmicro.com --- drivers/mfd/Kconfig |6 + drivers/mfd/Makefile |3 + drivers/mfd/arizona-core.c | 91 ++- drivers/mfd/arizona-irq.c| 42 +- drivers/mfd/arizona-spi.c|9 +