Re: [PATCH 1/3] mm/slob: Drop usage of page->private for storing page-sized allocations

2012-10-31 Thread Pekka Enberg
On Fri, Oct 19, 2012 at 1:41 AM, Ezequiel Garcia wrote: > This field was being used to store size allocation so it could be > retrieved by ksize(). However, it is a bad practice to not mark a page > as a slab page and then use fields for special purposes. > There is no need to store the allocated

Re: [PATCH 1/3] mm/slob: Drop usage of page-private for storing page-sized allocations

2012-10-31 Thread Pekka Enberg
On Fri, Oct 19, 2012 at 1:41 AM, Ezequiel Garcia elezegar...@gmail.com wrote: This field was being used to store size allocation so it could be retrieved by ksize(). However, it is a bad practice to not mark a page as a slab page and then use fields for special purposes. There is no need to

Re: [PATCH 1/3] mm/slob: Drop usage of page->private for storing page-sized allocations

2012-10-19 Thread Ezequiel Garcia
On Thu, Oct 18, 2012 at 7:46 PM, David Rientjes wrote: > On Thu, 18 Oct 2012, Ezequiel Garcia wrote: > >> This field was being used to store size allocation so it could be >> retrieved by ksize(). However, it is a bad practice to not mark a page >> as a slab page and then use fields for special

Re: [PATCH 1/3] mm/slob: Drop usage of page-private for storing page-sized allocations

2012-10-19 Thread Ezequiel Garcia
On Thu, Oct 18, 2012 at 7:46 PM, David Rientjes rient...@google.com wrote: On Thu, 18 Oct 2012, Ezequiel Garcia wrote: This field was being used to store size allocation so it could be retrieved by ksize(). However, it is a bad practice to not mark a page as a slab page and then use fields

Re: [PATCH 1/3] mm/slob: Drop usage of page->private for storing page-sized allocations

2012-10-18 Thread David Rientjes
On Thu, 18 Oct 2012, Ezequiel Garcia wrote: > This field was being used to store size allocation so it could be > retrieved by ksize(). However, it is a bad practice to not mark a page > as a slab page and then use fields for special purposes. > There is no need to store the allocated size and >

[PATCH 1/3] mm/slob: Drop usage of page->private for storing page-sized allocations

2012-10-18 Thread Ezequiel Garcia
This field was being used to store size allocation so it could be retrieved by ksize(). However, it is a bad practice to not mark a page as a slab page and then use fields for special purposes. There is no need to store the allocated size and ksize() can simply return PAGE_SIZE <<

[PATCH 1/3] mm/slob: Drop usage of page-private for storing page-sized allocations

2012-10-18 Thread Ezequiel Garcia
This field was being used to store size allocation so it could be retrieved by ksize(). However, it is a bad practice to not mark a page as a slab page and then use fields for special purposes. There is no need to store the allocated size and ksize() can simply return PAGE_SIZE

Re: [PATCH 1/3] mm/slob: Drop usage of page-private for storing page-sized allocations

2012-10-18 Thread David Rientjes
On Thu, 18 Oct 2012, Ezequiel Garcia wrote: This field was being used to store size allocation so it could be retrieved by ksize(). However, it is a bad practice to not mark a page as a slab page and then use fields for special purposes. There is no need to store the allocated size and