Re: [PATCH 1/3] mm: don't call activate_page() on new ksm pages

2020-08-17 Thread Yang Shi
On Thu, Aug 13, 2020 at 12:34 AM Yu Zhao wrote: > > On Wed, Aug 12, 2020 at 10:19:24PM -0700, Yang Shi wrote: > > On Tue, Aug 11, 2020 at 9:04 PM Yu Zhao wrote: > > > > > > lru_cache_add_active_or_unevictable() already adds new ksm pages to > > > active lru. Calling activate_page() isn't really n

Re: [PATCH 1/3] mm: don't call activate_page() on new ksm pages

2020-08-13 Thread Yu Zhao
On Wed, Aug 12, 2020 at 10:19:24PM -0700, Yang Shi wrote: > On Tue, Aug 11, 2020 at 9:04 PM Yu Zhao wrote: > > > > lru_cache_add_active_or_unevictable() already adds new ksm pages to > > active lru. Calling activate_page() isn't really necessary in this > > case. > > > > Signed-off-by: Yu Zhao >

Re: [PATCH 1/3] mm: don't call activate_page() on new ksm pages

2020-08-12 Thread Yang Shi
On Tue, Aug 11, 2020 at 9:04 PM Yu Zhao wrote: > > lru_cache_add_active_or_unevictable() already adds new ksm pages to > active lru. Calling activate_page() isn't really necessary in this > case. > > Signed-off-by: Yu Zhao > --- > mm/swapfile.c | 10 +- > 1 file changed, 5 insertions(+),

[PATCH 1/3] mm: don't call activate_page() on new ksm pages

2020-08-11 Thread Yu Zhao
lru_cache_add_active_or_unevictable() already adds new ksm pages to active lru. Calling activate_page() isn't really necessary in this case. Signed-off-by: Yu Zhao --- mm/swapfile.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/swapfile.c b/mm/swapfile.c index