Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-06-02 Thread Ulf Hansson
On 2 June 2016 at 11:35, Krzysztof Kozlowski wrote: > On Thu, Jun 2, 2016 at 10:31 AM, Ulf Hansson wrote: >> + Linus >> >> On 29 May 2016 at 09:04, Chen-Yu Tsai wrote: >>> When IS_ERR_VALUE was removed from the mmc core code, it was replaced >>> with a simple not-zero check. This does not work,

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-06-02 Thread Krzysztof Kozlowski
On Thu, Jun 2, 2016 at 10:31 AM, Ulf Hansson wrote: > + Linus > > On 29 May 2016 at 09:04, Chen-Yu Tsai wrote: >> When IS_ERR_VALUE was removed from the mmc core code, it was replaced >> with a simple not-zero check. This does not work, as the value checked >> is the return value for mmc_select_b

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-06-02 Thread Ulf Hansson
+ Linus On 29 May 2016 at 09:04, Chen-Yu Tsai wrote: > When IS_ERR_VALUE was removed from the mmc core code, it was replaced > with a simple not-zero check. This does not work, as the value checked > is the return value for mmc_select_bus_width, which returns the set > bit width on success. This

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-06-02 Thread Chen-Yu Tsai
On Thu, Jun 2, 2016 at 2:58 AM, Bjorn Andersson wrote: > On Sun, May 29, 2016 at 12:04 AM, Chen-Yu Tsai wrote: >> When IS_ERR_VALUE was removed from the mmc core code, it was replaced >> with a simple not-zero check. This does not work, as the value checked >> is the return value for mmc_select_b

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-06-01 Thread Bjorn Andersson
On Sun, May 29, 2016 at 12:04 AM, Chen-Yu Tsai wrote: > When IS_ERR_VALUE was removed from the mmc core code, it was replaced > with a simple not-zero check. This does not work, as the value checked > is the return value for mmc_select_bus_width, which returns the set > bit width on success. This

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-06-01 Thread Marcel Ziswiler
On Sun, 2016-05-29 at 15:04 +0800, Chen-Yu Tsai wrote: > When IS_ERR_VALUE was removed from the mmc core code, it was replaced > with a simple not-zero check. This does not work, as the value > checked > is the return value for mmc_select_bus_width, which returns the set > bit width on success. Thi

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-05-31 Thread Shawn Lin
On 2016/5/29 15:04, Chen-Yu Tsai wrote: When IS_ERR_VALUE was removed from the mmc core code, it was replaced with a simple not-zero check. This does not work, as the value checked is the return value for mmc_select_bus_width, which returns the set bit width on success. This made eMMC modes highe

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-05-31 Thread Jaehoon Chung
On 05/29/2016 04:04 PM, Chen-Yu Tsai wrote: > When IS_ERR_VALUE was removed from the mmc core code, it was replaced > with a simple not-zero check. This does not work, as the value checked > is the return value for mmc_select_bus_width, which returns the set > bit width on success. This made eMMC m

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-05-31 Thread Krzysztof Kozlowski
On Sun, May 29, 2016 at 9:04 AM, Chen-Yu Tsai wrote: > When IS_ERR_VALUE was removed from the mmc core code, it was replaced > with a simple not-zero check. This does not work, as the value checked > is the return value for mmc_select_bus_width, which returns the set > bit width on success. This m

[PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

2016-05-29 Thread Chen-Yu Tsai
When IS_ERR_VALUE was removed from the mmc core code, it was replaced with a simple not-zero check. This does not work, as the value checked is the return value for mmc_select_bus_width, which returns the set bit width on success. This made eMMC modes higher than HS-DDR unusable. Fix this by check