Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2016-01-06 Thread Brian Norris
On Tue, Aug 11, 2015 at 09:57:12PM +0200, Robert Jarzmik wrote: > Add verbose debug for register accesses. This enables easier debugging > by following where and how hardware is stimulated, and how it answers. > > Signed-off-by: Robert Jarzmik > --- > drivers/mtd/nand/pxa3xx_nand.c | 22

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2016-01-06 Thread Brian Norris
On Sat, Dec 19, 2015 at 01:19:26PM +0100, Robert Jarzmik wrote: > Brian Norris writes: > > > I don't have very strong opinions on this. It's kind of annoying to have > > this sort of stuff duplicated for every driver, if it's really needed. > > But I'll admit this kind of infrastructure is

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2016-01-06 Thread Brian Norris
On Sat, Dec 19, 2015 at 01:19:26PM +0100, Robert Jarzmik wrote: > Brian Norris writes: > > > I don't have very strong opinions on this. It's kind of annoying to have > > this sort of stuff duplicated for every driver, if it's really needed. > > But I'll admit this

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2016-01-06 Thread Brian Norris
On Tue, Aug 11, 2015 at 09:57:12PM +0200, Robert Jarzmik wrote: > Add verbose debug for register accesses. This enables easier debugging > by following where and how hardware is stimulated, and how it answers. > > Signed-off-by: Robert Jarzmik > --- >

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-12-19 Thread Robert Jarzmik
Brian Norris writes: > I don't have very strong opinions on this. It's kind of annoying to have > this sort of stuff duplicated for every driver, if it's really needed. > But I'll admit this kind of infrastructure is sometimes useful. > > Anecdote: I recently found the regmap trace event

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-12-19 Thread Robert Jarzmik
Brian Norris writes: > I don't have very strong opinions on this. It's kind of annoying to have > this sort of stuff duplicated for every driver, if it's really needed. > But I'll admit this kind of infrastructure is sometimes useful. > > Anecdote: I recently found

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-12-18 Thread Brian Norris
Garbage collecting some old patches before vacation... On Mon, Aug 24, 2015 at 10:46:18AM -0300, Ezequiel Garcia wrote: > I agree that the hack is useful for debugging purposes, it's just that I don't > see why we want it in mainline - where we usually avoid clutter. I'm not sure this is really

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-12-18 Thread Brian Norris
Garbage collecting some old patches before vacation... On Mon, Aug 24, 2015 at 10:46:18AM -0300, Ezequiel Garcia wrote: > I agree that the hack is useful for debugging purposes, it's just that I don't > see why we want it in mainline - where we usually avoid clutter. I'm not sure this is really

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-24 Thread Ezequiel Garcia
On 23 August 2015 at 16:09, Robert Jarzmik wrote: > Robert Jarzmik writes: > >> Ezequiel Garcia writes: >> >>> On 11 Aug 09:57 PM, Robert Jarzmik wrote: Add verbose debug for register accesses. This enables easier debugging by following where and how hardware is stimulated, and how it

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-24 Thread Ezequiel Garcia
On 23 August 2015 at 16:09, Robert Jarzmik robert.jarz...@free.fr wrote: Robert Jarzmik robert.jarz...@free.fr writes: Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: On 11 Aug 09:57 PM, Robert Jarzmik wrote: Add verbose debug for register accesses. This enables easier debugging by

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-23 Thread Robert Jarzmik
Robert Jarzmik writes: > Ezequiel Garcia writes: > >> On 11 Aug 09:57 PM, Robert Jarzmik wrote: >>> Add verbose debug for register accesses. This enables easier debugging >>> by following where and how hardware is stimulated, and how it answers. >>> >> >> I really don't see why we want this

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-23 Thread Robert Jarzmik
Robert Jarzmik robert.jarz...@free.fr writes: Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: On 11 Aug 09:57 PM, Robert Jarzmik wrote: Add verbose debug for register accesses. This enables easier debugging by following where and how hardware is stimulated, and how it answers. I

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-18 Thread Robert Jarzmik
Ezequiel Garcia writes: > On 11 Aug 09:57 PM, Robert Jarzmik wrote: >> Add verbose debug for register accesses. This enables easier debugging >> by following where and how hardware is stimulated, and how it answers. >> > > I really don't see why we want this patch. It's probably an useful hack

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-18 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: On 11 Aug 09:57 PM, Robert Jarzmik wrote: Add verbose debug for register accesses. This enables easier debugging by following where and how hardware is stimulated, and how it answers. I really don't see why we want this patch. It's

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-17 Thread Ezequiel Garcia
On 11 Aug 09:57 PM, Robert Jarzmik wrote: > Add verbose debug for register accesses. This enables easier debugging > by following where and how hardware is stimulated, and how it answers. > I really don't see why we want this patch. It's probably an useful hack to use in some cases, but can't

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-17 Thread Ezequiel Garcia
On 11 Aug 09:57 PM, Robert Jarzmik wrote: Add verbose debug for register accesses. This enables easier debugging by following where and how hardware is stimulated, and how it answers. I really don't see why we want this patch. It's probably an useful hack to use in some cases, but can't see

[PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-11 Thread Robert Jarzmik
Add verbose debug for register accesses. This enables easier debugging by following where and how hardware is stimulated, and how it answers. Signed-off-by: Robert Jarzmik --- drivers/mtd/nand/pxa3xx_nand.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff

[PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-11 Thread Robert Jarzmik
Add verbose debug for register accesses. This enables easier debugging by following where and how hardware is stimulated, and how it answers. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/mtd/nand/pxa3xx_nand.c | 22 +- 1 file changed, 17 insertions(+), 5