Re: [PATCH 1/3] net: phy: prevent linking breakage

2013-05-27 Thread Florian Fainelli
Hi, Le 27 mai 2013 19:38, "Alexandre Belloni" a écrit : [snip] > >> +/* > >> + * phy_register_fixup{,_for_uid,_for_id} are called from arch/ so this won't > >> + * work unless phylib is compiled in the kernel. > >> + * Defining stubs allows to prevent linking errors. > >> + */ > >> +#ifdef

Re: [PATCH 1/3] net: phy: prevent linking breakage

2013-05-27 Thread Alexandre Belloni
On 27/05/2013 18:39, Sascha Hauer wrote: > On Mon, May 27, 2013 at 06:18:42PM +0200, Alexandre Belloni wrote: >> phy_register_fixup{,_for_uid,_for_id} are called from arch/, quite >> often, there is no protection to check whether CONFIG_PHYLIB=y which is >> the only case where this would work.

Re: [PATCH 1/3] net: phy: prevent linking breakage

2013-05-27 Thread Sascha Hauer
On Mon, May 27, 2013 at 06:18:42PM +0200, Alexandre Belloni wrote: > phy_register_fixup{,_for_uid,_for_id} are called from arch/, quite > often, there is no protection to check whether CONFIG_PHYLIB=y which is > the only case where this would work. Having phylib as a module or not > compiled at

[PATCH 1/3] net: phy: prevent linking breakage

2013-05-27 Thread Alexandre Belloni
phy_register_fixup{,_for_uid,_for_id} are called from arch/, quite often, there is no protection to check whether CONFIG_PHYLIB=y which is the only case where this would work. Having phylib as a module or not compiled at all will result in that kind of linking failure:

[PATCH 1/3] net: phy: prevent linking breakage

2013-05-27 Thread Alexandre Belloni
phy_register_fixup{,_for_uid,_for_id} are called from arch/, quite often, there is no protection to check whether CONFIG_PHYLIB=y which is the only case where this would work. Having phylib as a module or not compiled at all will result in that kind of linking failure:

Re: [PATCH 1/3] net: phy: prevent linking breakage

2013-05-27 Thread Sascha Hauer
On Mon, May 27, 2013 at 06:18:42PM +0200, Alexandre Belloni wrote: phy_register_fixup{,_for_uid,_for_id} are called from arch/, quite often, there is no protection to check whether CONFIG_PHYLIB=y which is the only case where this would work. Having phylib as a module or not compiled at all

Re: [PATCH 1/3] net: phy: prevent linking breakage

2013-05-27 Thread Alexandre Belloni
On 27/05/2013 18:39, Sascha Hauer wrote: On Mon, May 27, 2013 at 06:18:42PM +0200, Alexandre Belloni wrote: phy_register_fixup{,_for_uid,_for_id} are called from arch/, quite often, there is no protection to check whether CONFIG_PHYLIB=y which is the only case where this would work. Having

Re: [PATCH 1/3] net: phy: prevent linking breakage

2013-05-27 Thread Florian Fainelli
Hi, Le 27 mai 2013 19:38, Alexandre Belloni alexandre.belloni@free- electrons.com a écrit : [snip] +/* + * phy_register_fixup{,_for_uid,_for_id} are called from arch/ so this won't + * work unless phylib is compiled in the kernel. + * Defining stubs allows to prevent linking errors.