From: Eric Biggers <ebigg...@google.com>

unlock_new_inode() is only meant to be called after a new inode has
already been inserted into the hash table.  But nilfs_new_inode() can
call it even before it has inserted the inode, triggering the WARNING in
unlock_new_inode().  Fix this by only calling unlock_new_inode() if the
inode has the I_NEW flag set, indicating that it's in the table.

Signed-off-by: Eric Biggers <ebigg...@google.com>
Signed-off-by: Ryusuke Konishi <konishi.ryus...@gmail.com>
---
 fs/nilfs2/inode.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c
index 28009ec54420..3318dd1350b2 100644
--- a/fs/nilfs2/inode.c
+++ b/fs/nilfs2/inode.c
@@ -388,7 +388,8 @@ struct inode *nilfs_new_inode(struct inode *dir, umode_t 
mode)
 
  failed_after_creation:
        clear_nlink(inode);
-       unlock_new_inode(inode);
+       if (inode->i_state & I_NEW)
+               unlock_new_inode(inode);
        iput(inode);  /*
                       * raw_inode will be deleted through
                       * nilfs_evict_inode().
-- 
1.8.3.1

Reply via email to