Re: [PATCH 1/3] perf callchain: Convert children list to rbtree

2013-09-23 Thread Jiri Olsa
On Mon, Sep 23, 2013 at 06:29:15PM +0900, Namhyung Kim wrote: > Hi, > > On Sun, 22 Sep 2013 13:15:59 +0200, Jiri Olsa wrote: > > On Tue, Sep 10, 2013 at 05:24:16PM +0900, Namhyung Kim wrote: > >> From: Namhyung Kim > > > > SNIP > > > >> index 2b585bc308cf..1b22b6269213 100644 > >> --- a/tools/per

Re: [PATCH 1/3] perf callchain: Convert children list to rbtree

2013-09-23 Thread Namhyung Kim
Hi, On Sun, 22 Sep 2013 13:15:59 +0200, Jiri Olsa wrote: > On Tue, Sep 10, 2013 at 05:24:16PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim > > SNIP > >> index 2b585bc308cf..1b22b6269213 100644 >> --- a/tools/perf/util/callchain.h >> +++ b/tools/perf/util/callchain.h >> @@ -21,10 +21,9 @@ enum

Re: [PATCH 1/3] perf callchain: Convert children list to rbtree

2013-09-22 Thread Jiri Olsa
On Tue, Sep 10, 2013 at 05:24:16PM +0900, Namhyung Kim wrote: > From: Namhyung Kim SNIP > index 2b585bc308cf..1b22b6269213 100644 > --- a/tools/perf/util/callchain.h > +++ b/tools/perf/util/callchain.h > @@ -21,10 +21,9 @@ enum chain_order { > > struct callchain_node { > struct callchai

Re: [PATCH 1/3] perf callchain: Convert children list to rbtree

2013-09-10 Thread Frederic Weisbecker
On Tue, Sep 10, 2013 at 12:25:54PM +0200, Ingo Molnar wrote: > > * Jiri Olsa wrote: > > > On Tue, Sep 10, 2013 at 05:24:16PM +0900, Namhyung Kim wrote: > > > From: Namhyung Kim > > > > > > Current collapse stage has a scalability problem which can be > > > reproduced easily with parallel kerne

Re: [PATCH 1/3] perf callchain: Convert children list to rbtree

2013-09-10 Thread Ingo Molnar
* Jiri Olsa wrote: > On Tue, Sep 10, 2013 at 05:24:16PM +0900, Namhyung Kim wrote: > > From: Namhyung Kim > > > > Current collapse stage has a scalability problem which can be > > reproduced easily with parallel kernel build. This is because it > > needs to traverse every children of callchai

Re: [PATCH 1/3] perf callchain: Convert children list to rbtree

2013-09-10 Thread Jiri Olsa
On Tue, Sep 10, 2013 at 05:24:16PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > Current collapse stage has a scalability problem which can be > reproduced easily with parallel kernel build. This is because it > needs to traverse every children of callchain linearly during the > collapse/m

Re: [PATCH 1/3] perf callchain: Convert children list to rbtree

2013-09-10 Thread Namhyung Kim
On Tue, 10 Sep 2013 17:24:16 +0900, Namhyung Kim wrote: > > - /* matches not, relay on the parent */ > + /* matches not, relay no the parent */ Argh.. please ignore this hunk. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

[PATCH 1/3] perf callchain: Convert children list to rbtree

2013-09-10 Thread Namhyung Kim
From: Namhyung Kim Current collapse stage has a scalability problem which can be reproduced easily with parallel kernel build. This is because it needs to traverse every children of callchain linearly during the collapse/merge stage. Convert it to rbtree reduced the overhead significantly. On