Re: [PATCH 1/3] perf session: Add perf_session__delete_env

2012-11-20 Thread Namhyung Kim
2012-11-20 (화), 12:13 -0300, Arnaldo Carvalho de Melo: > Em Tue, Nov 20, 2012 at 05:31:15PM +0800, Feng Tang escreveu: > > +static void perf_session__delete_env(struct perf_session *self) > > +{ > > + struct perf_session_env *env = &self->header.env; > > + > > + free(env->hostname); > > + fre

Re: [PATCH 1/3] perf session: Add perf_session__delete_env

2012-11-20 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 20, 2012 at 05:31:15PM +0800, Feng Tang escreveu: > +static void perf_session__delete_env(struct perf_session *self) > +{ > + struct perf_session_env *env = &self->header.env; > + > + free(env->hostname); > + free(env->os_release); > + free(env->version); > + free(en

[PATCH 1/3] perf session: Add perf_session__delete_env

2012-11-20 Thread Feng Tang
From: Namhyung Kim The perf session environment information was saved (so allocated) during perf_session__open, but was not freed. As free(3) handles NULL pointer input properly it won't cause a issue for writing modes - e.g. perf record. Signed-off-by: Namhyung Kim --- tools/perf/util/sessio