Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-20 Thread Stanislav Fomichev
> It (and others below) should be 'rec_argc -= 4' - i.e. I still see the > segfault. :) Damn, stupid me. > Looks like this change should be applied to the exsting (for cpu and > power events) boxes too. Care to send it as a separate fix? Yes, will add it as a first patch to the series, so it can

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-19 Thread Namhyung Kim
Hi Stanislav, On Thu, 19 Jun 2014 16:23:01 +0400, Stanislav Fomichev wrote: > In IO mode timechart shows any disk/network activity. > + for (i = 0; i < disk_events_nr; i++) { > + if (!is_valid_tracepoint(disk_events[i])) { > + rec_argc--; It (and others below)

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-19 Thread Namhyung Kim
Hi Stanislav, 2014-06-19 (목), 16:18 +0400, Stanislav Fomichev: > > > Hmm.. it looks like an unrelated issue. I can see the bars in inkscape, > > > but still see empty grey bars in firefox. > > I'll try to have a look; maybe I'm writing some non-standard svg > > instructions which fail on (probabl

[PATCH 1/3] perf timechart: implement IO mode

2014-06-19 Thread Stanislav Fomichev
In IO mode timechart shows any disk/network activity. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 613 +++- tools/perf/util/svghelper.c | 98 - tools/perf/ut

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-19 Thread Stanislav Fomichev
> > Hmm.. it looks like an unrelated issue. I can see the bars in inkscape, > > but still see empty grey bars in firefox. > I'll try to have a look; maybe I'm writing some non-standard svg > instructions which fail on (probably) standard-compliant firefox and > work on more robust inkscape. Found

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-19 Thread Stanislav Fomichev
> Hmm.. it looks like an unrelated issue. I can see the bars in inkscape, > but still see empty grey bars in firefox. I'll try to have a look; maybe I'm writing some non-standard svg instructions which fail on (probably) standard-compliant firefox and work on more robust inkscape. -- To unsubscrib

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-18 Thread Namhyung Kim
Hi Stanislav, On Wed, 18 Jun 2014 13:00:34 +0400, Stanislav Fomichev wrote: >> > Can you somehow share your perf.data with me? I'll check what's going >> > on. >> >> https://git.kernel.org/cgit/linux/kernel/git/namhyung/linux-perf.git/plain/tools/perf/perf.timechart.data?h=perf/tmp > Hm, I don't

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-18 Thread Stanislav Fomichev
> > Can you somehow share your perf.data with me? I'll check what's going > > on. > > https://git.kernel.org/cgit/linux/kernel/git/namhyung/linux-perf.git/plain/tools/perf/perf.timechart.data?h=perf/tmp Hm, I don't see any issue with your data, I can see dd disk io and firefox polls. I attached o

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-17 Thread Namhyung Kim
Hi Stanislav, On Mon, 16 Jun 2014 10:08:04 +0400, Stanislav Fomichev wrote: >> It was because, as I said, my system doesn't have pread64 syscall.. you >> missed to decrease rec_argc when skipping invalid events. :) > Thanks, missed that! > >> After fixing the problem, I could run timechart and gen

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-15 Thread Stanislav Fomichev
> It was because, as I said, my system doesn't have pread64 syscall.. you > missed to decrease rec_argc when skipping invalid events. :) Thanks, missed that! > After fixing the problem, I could run timechart and generate an > output.svg file. But it doesn't show any IO activity.. process info was

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-11 Thread Namhyung Kim
Hi Stanislav, On Tue, 10 Jun 2014 19:04:52 +0400, Stanislav Fomichev wrote: > In IO mode timechart shows any disk/network activity. [SNIP] > +Record system-wide IO events: > + > + $ perf timechart record -I I got a segfault here: Core was generated by `perf timechart record -I'. Program te

[PATCH 1/3] perf timechart: implement IO mode

2014-06-10 Thread Stanislav Fomichev
In IO mode timechart shows any disk/network activity. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 607 +++- tools/perf/util/svghelper.c | 98 - tools/perf/ut