Re: [PATCH 1/3] perf tools: Cache register accesses for unwind processing

2014-04-30 Thread Jiri Olsa
On Tue, Apr 29, 2014 at 09:36:19AM +0900, Namhyung Kim wrote: > On Mon, 28 Apr 2014 15:24:20 +0200, Jiri Olsa wrote: > > On Mon, Apr 28, 2014 at 10:02:55PM +0900, Namhyung Kim wrote: > >> Hi Jiri, > >> > >> 2014-04-28 (월), 11:48 +0200, Jiri Olsa: > >> > On Sun, Apr 27, 2014 at 11:29:21PM +0900, Na

Re: [PATCH 1/3] perf tools: Cache register accesses for unwind processing

2014-04-28 Thread Namhyung Kim
On Mon, 28 Apr 2014 15:24:20 +0200, Jiri Olsa wrote: > On Mon, Apr 28, 2014 at 10:02:55PM +0900, Namhyung Kim wrote: >> Hi Jiri, >> >> 2014-04-28 (월), 11:48 +0200, Jiri Olsa: >> > On Sun, Apr 27, 2014 at 11:29:21PM +0900, Namhyung Kim wrote: >> > > Hi Jiri, >> > > >> > > 2014-04-17 (목), 19:39 +02

Re: [PATCH 1/3] perf tools: Cache register accesses for unwind processing

2014-04-28 Thread Jiri Olsa
On Mon, Apr 28, 2014 at 10:02:55PM +0900, Namhyung Kim wrote: > Hi Jiri, > > 2014-04-28 (월), 11:48 +0200, Jiri Olsa: > > On Sun, Apr 27, 2014 at 11:29:21PM +0900, Namhyung Kim wrote: > > > Hi Jiri, > > > > > > 2014-04-17 (목), 19:39 +0200, Jiri Olsa: > > > > Caching registers value into an array.

Re: [PATCH 1/3] perf tools: Cache register accesses for unwind processing

2014-04-28 Thread Namhyung Kim
Hi Jiri, 2014-04-28 (월), 11:48 +0200, Jiri Olsa: > On Sun, Apr 27, 2014 at 11:29:21PM +0900, Namhyung Kim wrote: > > Hi Jiri, > > > > 2014-04-17 (목), 19:39 +0200, Jiri Olsa: > > > Caching registers value into an array. Got about 4% speed up > > > of perf_reg_value function for report command proc

Re: [PATCH 1/3] perf tools: Cache register accesses for unwind processing

2014-04-28 Thread Jiri Olsa
On Mon, Apr 28, 2014 at 12:39:24PM +0200, Christian Borntraeger wrote: SNIP > > { > > > > Want such a speedup, > but it does not compile on my s390x system: the speed up is for DWARF unwind report, which is not yet supported on s390x perf.. still it should compile ;-) I'll try to get some s

Re: [PATCH 1/3] perf tools: Cache register accesses for unwind processing

2014-04-28 Thread Christian Borntraeger
On 17/04/14 19:39, Jiri Olsa wrote: > Caching registers value into an array. Got about 4% speed up > of perf_reg_value function for report command processing > dwarf unwind stacks. > > Output from report over 1.5 GB data with DWARF unwind stacks: > (TODO fix perf diff) > > current code: >6.

Re: [PATCH 1/3] perf tools: Cache register accesses for unwind processing

2014-04-28 Thread Jiri Olsa
On Sun, Apr 27, 2014 at 11:29:21PM +0900, Namhyung Kim wrote: > Hi Jiri, > > 2014-04-17 (목), 19:39 +0200, Jiri Olsa: > > Caching registers value into an array. Got about 4% speed up > > of perf_reg_value function for report command processing > > dwarf unwind stacks. > > I'm not familiar with the

Re: [PATCH 1/3] perf tools: Cache register accesses for unwind processing

2014-04-27 Thread Namhyung Kim
Hi Jiri, 2014-04-17 (목), 19:39 +0200, Jiri Olsa: > Caching registers value into an array. Got about 4% speed up > of perf_reg_value function for report command processing > dwarf unwind stacks. I'm not familiar with the code base, so probably silly questions: Where does the speed up come from?

[PATCH 1/3] perf tools: Cache register accesses for unwind processing

2014-04-17 Thread Jiri Olsa
Caching registers value into an array. Got about 4% speed up of perf_reg_value function for report command processing dwarf unwind stacks. Output from report over 1.5 GB data with DWARF unwind stacks: (TODO fix perf diff) current code: 6.81% perf.old perf.old [.] perf_reg