Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

Em Fri, Oct 23, 2015 at 11:27:15AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Oct 23, 2015 at 11:59:32AM +0200, Ingo Molnar escreveu: > > Btw., another usability detail I noticed yesterday is that when I typed > > 'perf > > report -h' I got so much output that I couldn't find the

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

Em Fri, Oct 23, 2015 at 11:59:32AM +0200, Ingo Molnar escreveu: > Btw., another usability detail I noticed yesterday is that when I typed 'perf > report -h' I got so much output that I couldn't find the specific option I > was > looking for, because there's no apparent ordering of the output: >

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

* Namhyung Kim wrote: > > Also, I had to go into the code to decode the real meaning of all the other > > parameters. I'd have expected them to be more obvious from reading the help > > text. > > Did you check the man page also? I think we have (short) explanation for > each > parameter

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

* Namhyung Kim wrote: > > Also, I had to go into the code to decode the real meaning of all the other > > parameters. I'd have expected them to be more obvious from reading the help > > text. > > Did you check the man page also? I think we have (short) explanation for

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

Em Fri, Oct 23, 2015 at 11:27:15AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Oct 23, 2015 at 11:59:32AM +0200, Ingo Molnar escreveu: > > Btw., another usability detail I noticed yesterday is that when I typed > > 'perf > > report -h' I got so much output that I couldn't find the

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

Em Fri, Oct 23, 2015 at 11:59:32AM +0200, Ingo Molnar escreveu: > Btw., another usability detail I noticed yesterday is that when I typed 'perf > report -h' I got so much output that I couldn't find the specific option I > was > looking for, because there's no apparent ordering of the output: >

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

Em Thu, Oct 22, 2015 at 03:28:48PM +0900, Namhyung Kim escreveu: > These messages will be used by 'perf top' in the next patch. Applied -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

Em Thu, Oct 22, 2015 at 09:13:49PM +0900, Namhyung Kim escreveu: > On Thu, Oct 22, 2015 at 5:02 PM, Ingo Molnar wrote: > > > > * Namhyung Kim wrote: > > > >> +#define CALLCHAIN_HELP "setup and enables call-graph (stack > >> chain/backtrace) recording: " > >> + > >> +#ifdef

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

On Thu, Oct 22, 2015 at 5:02 PM, Ingo Molnar wrote: > > * Namhyung Kim wrote: > >> +#define CALLCHAIN_HELP "setup and enables call-graph (stack >> chain/backtrace) recording: " >> + >> +#ifdef HAVE_DWARF_UNWIND_SUPPORT >> +#define CALLCHAIN_RECORD_HELP CALLCHAIN_HELP "fp dwarf lbr" >> +#else

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

* Namhyung Kim wrote: > +#define CALLCHAIN_HELP "setup and enables call-graph (stack chain/backtrace) > recording: " > + > +#ifdef HAVE_DWARF_UNWIND_SUPPORT > +#define CALLCHAIN_RECORD_HELP CALLCHAIN_HELP "fp dwarf lbr" > +#else > +#define CALLCHAIN_RECORD_HELP CALLCHAIN_HELP "fp lbr" >

[PATCH 1/3] perf tools: Move callchain help messages to callchain.h

These messages will be used by 'perf top' in the next patch. Cc: Adrian Hunter Cc: Borislav Petkov Cc: Chandler Carruth Cc: Frederic Weisbecker Cc: Stephane Eranian Cc: Wang Nan Cc: Brendan Gregg Signed-off-by: Namhyung Kim --- tools/perf/builtin-record.c | 8 +---

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

* Namhyung Kim wrote: > +#define CALLCHAIN_HELP "setup and enables call-graph (stack chain/backtrace) > recording: " > + > +#ifdef HAVE_DWARF_UNWIND_SUPPORT > +#define CALLCHAIN_RECORD_HELP CALLCHAIN_HELP "fp dwarf lbr" > +#else > +#define CALLCHAIN_RECORD_HELP

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

Em Thu, Oct 22, 2015 at 03:28:48PM +0900, Namhyung Kim escreveu: > These messages will be used by 'perf top' in the next patch. Applied -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

On Thu, Oct 22, 2015 at 5:02 PM, Ingo Molnar wrote: > > * Namhyung Kim wrote: > >> +#define CALLCHAIN_HELP "setup and enables call-graph (stack >> chain/backtrace) recording: " >> + >> +#ifdef HAVE_DWARF_UNWIND_SUPPORT >> +#define CALLCHAIN_RECORD_HELP

Re: [PATCH 1/3] perf tools: Move callchain help messages to callchain.h

Em Thu, Oct 22, 2015 at 09:13:49PM +0900, Namhyung Kim escreveu: > On Thu, Oct 22, 2015 at 5:02 PM, Ingo Molnar wrote: > > > > * Namhyung Kim wrote: > > > >> +#define CALLCHAIN_HELP "setup and enables call-graph (stack > >> chain/backtrace) recording: " >

[PATCH 1/3] perf tools: Move callchain help messages to callchain.h

These messages will be used by 'perf top' in the next patch. Cc: Adrian Hunter Cc: Borislav Petkov Cc: Chandler Carruth Cc: Frederic Weisbecker Cc: Stephane Eranian Cc: Wang Nan