Re: [PATCH 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use

2020-11-17 Thread Amjad Ouled-Ameur
Hi Martin, On 14/11/2020 20:13, Martin Blumenstingl wrote: Hi Amjad, On Fri, Nov 13, 2020 at 1:06 AM Amjad Ouled-Ameur wrote: [...] @@ -124,6 +126,7 @@ static int phy_meson_gxl_usb2_exit(struct phy *phy) { struct phy_meson_gxl_usb2_priv *priv = phy_get_drvdata(phy); + reset

Re: [PATCH 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use

2020-11-14 Thread Martin Blumenstingl
Hi Amjad, On Fri, Nov 13, 2020 at 1:06 AM Amjad Ouled-Ameur wrote: [...] > @@ -124,6 +126,7 @@ static int phy_meson_gxl_usb2_exit(struct phy *phy) > { > struct phy_meson_gxl_usb2_priv *priv = phy_get_drvdata(phy); > > + reset_control_rearm(priv->reset); please move reset_control_re

[PATCH 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use

2020-11-12 Thread Amjad Ouled-Ameur
Use reset_control_rearm() call if an error occurs in case phy_meson_gxl_usb2_init() fails after reset() has been called ; or in case phy_meson_gxl_usb2_exit() is called i.e the resource is no longer used and the reset line may be triggered again by other devices. reset_control_rearm() keeps use of