Re: [PATCH 1/3] pinctrl: add compatible for Amlogic Meson A1 pin controller

2019-09-30 Thread Rob Herring
On Tue, 17 Sep 2019 14:07:20 +0800, Qianggui Song wrote: > Add new compatible name for Amlogic's Meson-A1 pin controller > add a dt-binding header file which document the detail pin names. > > Signed-off-by: Qianggui Song > Signed-off-by: Xingyu Chen > Signed-off-by: Jianxin Pan > --- > .../de

Re: [PATCH 1/3] pinctrl: add compatible for Amlogic Meson A1 pin controller

2019-09-17 Thread Qianggui Song
Hi, Neil Thanks for your review On 2019/9/17 15:18, Neil Armstrong wrote: > Hi, > > On 17/09/2019 08:07, Qianggui Song wrote: >> Add new compatible name for Amlogic's Meson-A1 pin controller >> add a dt-binding header file which document the detail pin names. > > Please add in the commit

Re: [PATCH 1/3] pinctrl: add compatible for Amlogic Meson A1 pin controller

2019-09-17 Thread Neil Armstrong
Hi, On 17/09/2019 08:07, Qianggui Song wrote: > Add new compatible name for Amlogic's Meson-A1 pin controller > add a dt-binding header file which document the detail pin names. Please add in the commit log that A1 doesn't need the DS bank reg, so when we will convert these bindings to yaml we wi

[PATCH 1/3] pinctrl: add compatible for Amlogic Meson A1 pin controller

2019-09-16 Thread Qianggui Song
Add new compatible name for Amlogic's Meson-A1 pin controller add a dt-binding header file which document the detail pin names. Signed-off-by: Qianggui Song Signed-off-by: Xingyu Chen Signed-off-by: Jianxin Pan --- .../devicetree/bindings/pinctrl/meson,pinctrl.txt | 1 + include/dt-bindings/