Re: [PATCH 1/3] pinctrl: mcp23s08: Fixup mcp23x17 regmap_config

2020-08-28 Thread Thomas Preston
Hey Andy, Linus, Thanks for looking at this. On 28/08/2020 11:09, Andy Shevchenko wrote: On Fri, Aug 14, 2020 at 1:35 PM Thomas Preston wrote: - Fix a typo where mcp23x17 configs are referred to as mcp23x16. I'm not sure it's correct. MPC23016 is an existing I²C IO expander. The MCP23016

Re: [PATCH 1/3] pinctrl: mcp23s08: Fixup mcp23x17 regmap_config

2020-08-28 Thread Thomas Preston
On 28/08/2020 10:28, Andy Shevchenko wrote: On Fri, Aug 28, 2020 at 11:06:21AM +0200, Linus Walleij wrote: On Fri, Aug 14, 2020 at 12:04 PM Thomas Preston wrote: - Fix a typo where mcp23x17 configs are referred to as mcp23x16. - Fix precious range to include INTCAP{A,B}, which clear on read.

Re: [PATCH 1/3] pinctrl: mcp23s08: Fixup mcp23x17 regmap_config

2020-08-28 Thread Andy Shevchenko
On Fri, Aug 14, 2020 at 1:35 PM Thomas Preston wrote: > > - Fix a typo where mcp23x17 configs are referred to as mcp23x16. I'm not sure it's correct. MPC23016 is an existing I²C IO expander. > - Fix precious range to include INTCAP{A,B}, which clear on read. > - Fix precious range to include GPI

Re: [PATCH 1/3] pinctrl: mcp23s08: Fixup mcp23x17 regmap_config

2020-08-28 Thread Andy Shevchenko
On Fri, Aug 28, 2020 at 11:06:21AM +0200, Linus Walleij wrote: > On Fri, Aug 14, 2020 at 12:04 PM Thomas Preston > wrote: > > > - Fix a typo where mcp23x17 configs are referred to as mcp23x16. > > - Fix precious range to include INTCAP{A,B}, which clear on read. > > - Fix precious range to includ

Re: [PATCH 1/3] pinctrl: mcp23s08: Fixup mcp23x17 regmap_config

2020-08-28 Thread Linus Walleij
On Fri, Aug 14, 2020 at 12:04 PM Thomas Preston wrote: > - Fix a typo where mcp23x17 configs are referred to as mcp23x16. > - Fix precious range to include INTCAP{A,B}, which clear on read. > - Fix precious range to include GPIOB, which clears on read. > - Fix volatile range to include GPIOB, to

[PATCH 1/3] pinctrl: mcp23s08: Fixup mcp23x17 regmap_config

2020-08-14 Thread Thomas Preston
- Fix a typo where mcp23x17 configs are referred to as mcp23x16. - Fix precious range to include INTCAP{A,B}, which clear on read. - Fix precious range to include GPIOB, which clears on read. - Fix volatile range to include GPIOB, to fix debugfs registers reporting different values than `gpioget