RE: [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario.Limonciello
gt; Cc: Darren Hart <dvh...@infradead.org>; Pali Rohár <pali.ro...@gmail.com>; > LKML <linux-kernel@vger.kernel.org>; Platform Driver x...@vger.kernel.org> > Subject: Re: [PATCH 1/3] platform/x86: dell-smbios: Correct some style > warnings > > On Tue, Feb 27, 2018 at 5:5

RE: [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario.Limonciello
; Platform Driver x...@vger.kernel.org> > Subject: Re: [PATCH 1/3] platform/x86: dell-smbios: Correct some style > warnings > > On Tue, Feb 27, 2018 at 5:56 PM, Mario Limonciello > wrote: > > > /* 4 bytes of table header, plus 7 bytes of Dell header, pl

Re: [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Andy Shevchenko
On Tue, Feb 27, 2018 at 5:56 PM, Mario Limonciello wrote: > /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least > - 6 bytes of entry */ > +* 6 bytes of entry > +*/ I would prefer not to mix with net style, since you

Re: [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Andy Shevchenko
On Tue, Feb 27, 2018 at 5:56 PM, Mario Limonciello wrote: > /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least > - 6 bytes of entry */ > +* 6 bytes of entry > +*/ I would prefer not to mix with net style, since you are fixing this, perhaps

[PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario Limonciello
WARNING: function definition argument 'struct calling_interface_buffer *' should also have an identifier name + int (*call_fn)(struct calling_interface_buffer *); WARNING: Block comments use * on subsequent lines + /* 4 bytes of table header, plus 7 bytes of Dell header, plus

[PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario Limonciello
WARNING: function definition argument 'struct calling_interface_buffer *' should also have an identifier name + int (*call_fn)(struct calling_interface_buffer *); WARNING: Block comments use * on subsequent lines + /* 4 bytes of table header, plus 7 bytes of Dell header, plus