Re: [PATCH 1/3] power: validate wakeup source before activating it.

2015-04-27 Thread Jin Qian
This is a rare case. My thought is to prevent a rogue wakeup source from preventing system suspend, which is very difficult to find out if the wakeup source is not registered and not visible in /d/wakeup_sources. On the other hand, if the wakeup source failed to activate, it's much easier to be no

Re: [PATCH 1/3] power: validate wakeup source before activating it.

2015-04-25 Thread Pavel Machek
On Wed 2015-04-22 17:50:10, Jin Qian wrote: > A rogue wakeup source not registered in wakeup_sources list is not visible > from wakeup_sources_stats_show. Check if the wakeup source is registered > properly by looking at the timer function. How often does that happen? Will people on your systems

[PATCH 1/3] power: validate wakeup source before activating it.

2015-04-22 Thread Jin Qian
A rogue wakeup source not registered in wakeup_sources list is not visible from wakeup_sources_stats_show. Check if the wakeup source is registered properly by looking at the timer function. Signed-off-by: Jin Qian --- drivers/base/power/wakeup.c | 19 +++ 1 file changed, 19 inse