Re: Fwd: Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-19 Thread Alexander Sverdlin
Hello! On 08/19/2013 10:25 AM, Ionut Nicu wrote: > Original Message > Subject: Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap > Date: Fri, 09 Aug 2013 19:16:49 +0200 > From: Ionut Nicu > To: ext Mark Brown > CC: Greg Kroah-Hartman , > linux-k

Re: Fwd: Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-19 Thread Alexander Sverdlin
Hello! On 08/19/2013 10:25 AM, Ionut Nicu wrote: Original Message Subject: Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap Date: Fri, 09 Aug 2013 19:16:49 +0200 From: Ionut Nicu ioan.nicu@nsn.com To: ext Mark Brown broo...@kernel.org CC: Greg Kroah-Hartman

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-13 Thread Mark Brown
On Tue, Aug 13, 2013 at 09:17:12AM +0200, Ionut Nicu wrote: > Do you have any feedback for this patch? Not yet, please allow some time for response especially over weekends. > If you think the change is too complex, I have a simpler solution that could > make > things work with devices

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-13 Thread Ionut Nicu
Hi Mark, On 09.08.2013 19:16, Ionut Nicu wrote: > On 09.08.2013 13:44, ext Mark Brown wrote: >> On Fri, Aug 09, 2013 at 12:09:11PM +0200, Ionut Nicu wrote: >>> As opposed to the other regmap cache implementations, >>> regcache_flat didn't use the cache_present bitmap for >>> figuring out whether

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-13 Thread Ionut Nicu
Hi Mark, On 09.08.2013 19:16, Ionut Nicu wrote: On 09.08.2013 13:44, ext Mark Brown wrote: On Fri, Aug 09, 2013 at 12:09:11PM +0200, Ionut Nicu wrote: As opposed to the other regmap cache implementations, regcache_flat didn't use the cache_present bitmap for figuring out whether a register

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-13 Thread Mark Brown
On Tue, Aug 13, 2013 at 09:17:12AM +0200, Ionut Nicu wrote: Do you have any feedback for this patch? Not yet, please allow some time for response especially over weekends. If you think the change is too complex, I have a simpler solution that could make things work with devices that

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-09 Thread Ionut Nicu
On 09.08.2013 13:44, ext Mark Brown wrote: > On Fri, Aug 09, 2013 at 12:09:11PM +0200, Ionut Nicu wrote: >> As opposed to the other regmap cache implementations, >> regcache_flat didn't use the cache_present bitmap for >> figuring out whether a register was cached or not, nor >> did it mark a

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-09 Thread Mark Brown
On Fri, Aug 09, 2013 at 12:09:11PM +0200, Ionut Nicu wrote: > As opposed to the other regmap cache implementations, > regcache_flat didn't use the cache_present bitmap for > figuring out whether a register was cached or not, nor > did it mark a register as present in the cache when >

[PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-09 Thread Ionut Nicu
As opposed to the other regmap cache implementations, regcache_flat didn't use the cache_present bitmap for figuring out whether a register was cached or not, nor did it mark a register as present in the cache when regcache_flat_write() was called. This caused incorrect behaviour, such as

[PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-09 Thread Ionut Nicu
As opposed to the other regmap cache implementations, regcache_flat didn't use the cache_present bitmap for figuring out whether a register was cached or not, nor did it mark a register as present in the cache when regcache_flat_write() was called. This caused incorrect behaviour, such as

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-09 Thread Mark Brown
On Fri, Aug 09, 2013 at 12:09:11PM +0200, Ionut Nicu wrote: As opposed to the other regmap cache implementations, regcache_flat didn't use the cache_present bitmap for figuring out whether a register was cached or not, nor did it mark a register as present in the cache when

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-09 Thread Ionut Nicu
On 09.08.2013 13:44, ext Mark Brown wrote: On Fri, Aug 09, 2013 at 12:09:11PM +0200, Ionut Nicu wrote: As opposed to the other regmap cache implementations, regcache_flat didn't use the cache_present bitmap for figuring out whether a register was cached or not, nor did it mark a register as