Re: [PATCH 1/3] regulator: pbias: Fix is_enabled callback implementation

2014-03-07 Thread Balaji T K
On Friday 07 March 2014 09:11 PM, Axel Lin wrote: The is_enabled implementation is wrong in some cases: e.g. for pbias_mmc_omap5: emable_mask is : BIT(27) | BIT(25) | BIT(26) Hi Axel, s/emable_mask/enable_mask However, pbias_regulator_enable() only sets BIT(26) | BIT(22) bits. You mixed up

[PATCH 1/3] regulator: pbias: Fix is_enabled callback implementation

2014-03-07 Thread Axel Lin
The is_enabled implementation is wrong in some cases: e.g. for pbias_mmc_omap5: emable_mask is : BIT(27) | BIT(25) | BIT(26) However, pbias_regulator_enable() only sets BIT(26) | BIT(22) bits. So is_enabled callback will always return false in this case. Fix the logic to compare the register value