Re: [PATCH 1/3] staging: dgap: remove unneeded status variables

2014-03-06 Thread Greg Kroah-Hartman
On Mon, Mar 03, 2014 at 01:08:06AM +0400, Alexey Khoroshilov wrote: > dgap_driver_start and dgap_Major_Control_Registered are used > to keep status of initialization of the driver as a whole and its "Major > Control". > But the code that checks them is executed once on module init/unload. > That

Re: [PATCH 1/3] staging: dgap: remove unneeded status variables

2014-03-06 Thread Greg Kroah-Hartman
On Mon, Mar 03, 2014 at 01:08:06AM +0400, Alexey Khoroshilov wrote: dgap_driver_start and dgap_Major_Control_Registered are used to keep status of initialization of the driver as a whole and its Major Control. But the code that checks them is executed once on module init/unload. That makes

[PATCH 1/3] staging: dgap: remove unneeded status variables

2014-03-02 Thread Alexey Khoroshilov
dgap_driver_start and dgap_Major_Control_Registered are used to keep status of initialization of the driver as a whole and its "Major Control". But the code that checks them is executed once on module init/unload. That makes no sense in these variables as far as their values are predictable at

[PATCH 1/3] staging: dgap: remove unneeded status variables

2014-03-02 Thread Alexey Khoroshilov
dgap_driver_start and dgap_Major_Control_Registered are used to keep status of initialization of the driver as a whole and its Major Control. But the code that checks them is executed once on module init/unload. That makes no sense in these variables as far as their values are predictable at any

Re: [PATCH 1/3] staging: dgap: remove unneeded status variables

2014-02-24 Thread Greg Kroah-Hartman
On Mon, Feb 24, 2014 at 12:21:51AM +0400, Alexey Khoroshilov wrote: > dgap_driver_start and dgap_Major_Control_Registered are used > to keep status of initialization of the driver as a whole and its "Major > Control". > But the code that checks them is executed once on module init/unload. > That

Re: [PATCH 1/3] staging: dgap: remove unneeded status variables

2014-02-24 Thread Greg Kroah-Hartman
On Mon, Feb 24, 2014 at 12:21:51AM +0400, Alexey Khoroshilov wrote: dgap_driver_start and dgap_Major_Control_Registered are used to keep status of initialization of the driver as a whole and its Major Control. But the code that checks them is executed once on module init/unload. That makes

[PATCH 1/3] staging: dgap: remove unneeded status variables

2014-02-23 Thread Alexey Khoroshilov
dgap_driver_start and dgap_Major_Control_Registered are used to keep status of initialization of the driver as a whole and its "Major Control". But the code that checks them is executed once on module init/unload. That makes no sense in these variables as far as their values are predictable at

[PATCH 1/3] staging: dgap: remove unneeded status variables

2014-02-23 Thread Alexey Khoroshilov
dgap_driver_start and dgap_Major_Control_Registered are used to keep status of initialization of the driver as a whole and its Major Control. But the code that checks them is executed once on module init/unload. That makes no sense in these variables as far as their values are predictable at any