Re: [PATCH 1/3] staging: panel: (coding style) Matching braces

2014-05-26 Thread Willy Tarreau
On Mon, May 26, 2014 at 10:28:10AM -0700, Joe Perches wrote: > On Mon, 2014-05-26 at 16:28 +0200, Willy Tarreau wrote: > > I believe that most of the kernel code prefers the two-line format resluting > > in this instead : > > > > } > > else if (*esc >= 'A' && *esc <= 'Z') {

Re: [PATCH 1/3] staging: panel: (coding style) Matching braces

2014-05-26 Thread Joe Perches
On Mon, 2014-05-26 at 16:28 +0200, Willy Tarreau wrote: > I believe that most of the kernel code prefers the two-line format resluting > in this instead : > > } > else if (*esc >= 'A' && *esc <= 'Z') { > value |= (*esc - 'A' + 10) << shift; >

Re: [PATCH 1/3] staging: panel: (coding style) Matching braces

2014-05-26 Thread Willy Tarreau
On Mon, May 26, 2014 at 04:45:05PM +0200, Dominique van den Broeck wrote: > > Hello Willy, > > > I don't want to be nit-picking, but since we're talking about style... > > for me these "} else {" statements are harder to parse than having them > > on two lines this way : > > <...> > > > > It's ju

Re: [PATCH 1/3] staging: panel: (coding style) Matching braces

2014-05-26 Thread Dominique van den Broeck
Hello Willy, > I don't want to be nit-picking, but since we're talking about style... > for me these "} else {" statements are harder to parse than having them > on two lines this way : > <...> > > It's just a matter of taste I know, but for me they read easier, probably > because the braces do n

Re: [PATCH 1/3] staging: panel: (coding style) Matching braces

2014-05-26 Thread Willy Tarreau
Hi Dominique, On Wed, May 21, 2014 at 02:09:59PM +0200, Dominique van den Broeck wrote: > Style-only modifications to comply with checkpatch.pl --strict --file. > . Adds every missing brace in condition statements. > > Signed-off-by: Dominique van den Broeck > --- > Apply on linux-next tree, ab

[PATCH 1/3] staging: panel: (coding style) Matching braces

2014-05-21 Thread Dominique van den Broeck
Style-only modifications to comply with checkpatch.pl --strict --file. . Adds every missing brace in condition statements. Signed-off-by: Dominique van den Broeck --- Apply on linux-next tree, above: commit 4151fa6adc65da14673ece623bbb2acc6936f8be "Add linux-next specific files for 20140516" di