Re: [PATCH 1/3] target/sbc: Make WRITE_SAME check differentiate between UNMAP=[1,0]

2012-11-15 Thread Christoph Hellwig
> + if (flags[0] & 0x08) > + cmd->se_cmd_flags |= SCF_WRITE_SAME_DISCARD; I don't like this flag at all. We can still simply check the CDB during ->execute_cmd and avoid this redundant flag. Except for that bit the changes look fine, but should not be a patch on their own.

Re: [PATCH 1/3] target/sbc: Make WRITE_SAME check differentiate between UNMAP=[1,0]

2012-11-15 Thread Christoph Hellwig
+ if (flags[0] 0x08) + cmd-se_cmd_flags |= SCF_WRITE_SAME_DISCARD; I don't like this flag at all. We can still simply check the CDB during -execute_cmd and avoid this redundant flag. Except for that bit the changes look fine, but should not be a patch on their own. Without

[PATCH 1/3] target/sbc: Make WRITE_SAME check differentiate between UNMAP=[1,0]

2012-11-08 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates sbc_write_same_supported() to set SCF_WRITE_SAME_DISCARD to signal when WRITE_SAME w/ UNMAP=1 is requested. Also, allow WRITE_SAME w/ UNMAP=0 to be passed to backend driver logic. Cc: Christoph Hellwig Cc: Martin K. Petersen Signed-off-by: Nicholas

[PATCH 1/3] target/sbc: Make WRITE_SAME check differentiate between UNMAP=[1,0]

2012-11-08 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates sbc_write_same_supported() to set SCF_WRITE_SAME_DISCARD to signal when WRITE_SAME w/ UNMAP=1 is requested. Also, allow WRITE_SAME w/ UNMAP=0 to be passed to backend driver logic. Cc: Christoph Hellwig h...@lst.de Cc: Martin K.