Re: [PATCH 1/3] thunderbolt: Remove superfluous check

2017-08-30 Thread gre...@linuxfoundation.org
On Wed, Aug 30, 2017 at 02:00:53PM +, Bernat, Yehezkel wrote: > On Mon, 2017-08-28 at 16:20 +0200, Greg Kroah-Hartman wrote: > > On Sun, Aug 27, 2017 at 04:31:27PM +0300, Mika Westerberg wrote: > > > > > > On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote: > > > > > > > > On Tue

Re: [PATCH 1/3] thunderbolt: Remove superfluous check

2017-08-30 Thread Bernat, Yehezkel
On Mon, 2017-08-28 at 16:20 +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 27, 2017 at 04:31:27PM +0300, Mika Westerberg wrote: > > > > On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote: > > > > > > On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote: > > > > > > > > T

Re: [PATCH 1/3] thunderbolt: Remove superfluous check

2017-08-28 Thread Greg Kroah-Hartman
On Sun, Aug 27, 2017 at 04:31:27PM +0300, Mika Westerberg wrote: > On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote: > > On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote: > > > The key size is tested by hex2bin() already (as '\0' isn't an hex digit) > > > > > > Sugge

Re: [PATCH 1/3] thunderbolt: Remove superfluous check

2017-08-27 Thread Mika Westerberg
On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote: > On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote: > > The key size is tested by hex2bin() already (as '\0' isn't an hex digit) > > > > Suggested-by: Andy Shevchenko > > Signed-off-by: Yehezkel Bernat > > Acked-by

Re: [PATCH 1/3] thunderbolt: Remove superfluous check

2017-08-15 Thread Andy Shevchenko
On Tue, Aug 15, 2017 at 8:19 AM, Bernat, Yehezkel wrote: > The key size is tested by hex2bin() already (as '\0' isn't an hex digit) Yes, and it's guaranteed (by kernelfs) that '\0' will be there sooner or later. > Suggested-by: Andy Shevchenko I'm using @linux.intel.com, though for this tag it

Re: [PATCH 1/3] thunderbolt: Remove superfluous check

2017-08-15 Thread Mika Westerberg
On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote: > The key size is tested by hex2bin() already (as '\0' isn't an hex digit) > > Suggested-by: Andy Shevchenko > Signed-off-by: Yehezkel Bernat Acked-by: Mika Westerberg

[PATCH 1/3] thunderbolt: Remove superfluous check

2017-08-14 Thread Bernat, Yehezkel
The key size is tested by hex2bin() already (as '\0' isn't an hex digit) Suggested-by: Andy Shevchenko Signed-off-by: Yehezkel Bernat --- drivers/thunderbolt/switch.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index e9391bb.