Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Lars-Peter Clausen
On 10/31/2012 07:43 PM, Pantelis Antoniou wrote: > > On Oct 31, 2012, at 8:36 PM, Lars-Peter Clausen wrote: > >> On 10/31/2012 07:12 PM, Pantelis Antoniou wrote: >>> >>> On Oct 31, 2012, at 8:07 PM, Lars-Peter Clausen wrote: >>> On 10/31/2012 06:55 PM, Pantelis Antoniou wrote: > [...] >>

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Pantelis Antoniou
On Oct 31, 2012, at 8:36 PM, Lars-Peter Clausen wrote: > On 10/31/2012 07:12 PM, Pantelis Antoniou wrote: >> >> On Oct 31, 2012, at 8:07 PM, Lars-Peter Clausen wrote: >> >>> On 10/31/2012 06:55 PM, Pantelis Antoniou wrote: [...] >> } >> >> indio_dev->channels = chan_array; >

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Lars-Peter Clausen
On 10/31/2012 07:12 PM, Pantelis Antoniou wrote: > > On Oct 31, 2012, at 8:07 PM, Lars-Peter Clausen wrote: > >> On 10/31/2012 06:55 PM, Pantelis Antoniou wrote: >>> [...] > } > > indio_dev->channels = chan_array; > + indio_dev->num_channels = channels; > + > + size =

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Porter, Matt
On Oct 31, 2012, at 1:55 PM, Pantelis Antoniou wrote: > > On Oct 31, 2012, at 7:52 PM, Lars-Peter Clausen wrote: > >> On 11/01/2012 04:24 PM, Pantelis Antoniou wrote: >>> Add an IIO map interface that consumers can use. >> >> Hi, >> >> Looks like you overlooked the review comments I had inlin

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Pantelis Antoniou
On Oct 31, 2012, at 8:07 PM, Lars-Peter Clausen wrote: > On 10/31/2012 06:55 PM, Pantelis Antoniou wrote: >> [...] } indio_dev->channels = chan_array; + indio_dev->num_channels = channels; + + size = (channels + 1) * sizeof(struct iio_map); + adc_dev->

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Lars-Peter Clausen
On 10/31/2012 06:55 PM, Pantelis Antoniou wrote: > [...] >>> } >>> >>> indio_dev->channels = chan_array; >>> + indio_dev->num_channels = channels; >>> + >>> + size = (channels + 1) * sizeof(struct iio_map); >>> + adc_dev->map = kzalloc(size, GFP_KERNEL); >>> + if (adc_dev->map == NU

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Pantelis Antoniou
On Oct 31, 2012, at 7:52 PM, Lars-Peter Clausen wrote: > On 11/01/2012 04:24 PM, Pantelis Antoniou wrote: >> Add an IIO map interface that consumers can use. > > Hi, > > Looks like you overlooked the review comments I had inline last time. I've > put them in again, see below. > >> >> Signed-o

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Lars-Peter Clausen
On 11/01/2012 04:24 PM, Pantelis Antoniou wrote: > Add an IIO map interface that consumers can use. Hi, Looks like you overlooked the review comments I had inline last time. I've put them in again, see below. > > Signed-off-by: Pantelis Antoniou > --- > drivers/iio/adc/ti_am335x_adc.c | 60 >

[PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Pantelis Antoniou
Add an IIO map interface that consumers can use. Signed-off-by: Pantelis Antoniou --- drivers/iio/adc/ti_am335x_adc.c | 60 + 1 file changed, 49 insertions(+), 11 deletions(-) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c