Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-17 Thread Jeff Liu
On 07/16/2012 05:28 PM, Hugh Dickins wrote: > On Thu, 12 Jul 2012, Jeff Liu wrote: >> On 07/12/2012 07:01 AM, Dave Chinner wrote: >>> On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: But your vote would count for a lot more if you know of some app which would really

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-17 Thread Jeff Liu
On 07/16/2012 05:28 PM, Hugh Dickins wrote: On Thu, 12 Jul 2012, Jeff Liu wrote: On 07/12/2012 07:01 AM, Dave Chinner wrote: On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: But your vote would count for a lot more if you know of some app which would really benefit from this

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-16 Thread Hugh Dickins
On Thu, 12 Jul 2012, Jeff Liu wrote: > On 07/12/2012 07:01 AM, Dave Chinner wrote: > > On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: > >> > >> But your vote would count for a lot more if you know of some app which > >> would really benefit from this functionality in tmpfs: I've

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-16 Thread Hugh Dickins
On Thu, 12 Jul 2012, Jeff Liu wrote: On 07/12/2012 07:01 AM, Dave Chinner wrote: On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: But your vote would count for a lot more if you know of some app which would really benefit from this functionality in tmpfs: I've heard of none.

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-11 Thread Jeff Liu
On 07/12/2012 07:01 AM, Dave Chinner wrote: > On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: >> On Wed, 11 Jul 2012, Cong Wang wrote: >>> On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins wrote: Revert 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE"). I believe it's

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-11 Thread Hugh Dickins
On Thu, 12 Jul 2012, Dave Chinner wrote: > On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: > > On Wed, 11 Jul 2012, Cong Wang wrote: > > > > > > If you don't have burden to maintain it, I'd prefer to leave as it is, > > > I don't think 752-bytes is the reason we revert it. > > > >

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-11 Thread Dave Chinner
On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: > On Wed, 11 Jul 2012, Cong Wang wrote: > > On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins wrote: > > > Revert 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE"). > > > I believe it's correct, and it's been nice to have from rc1

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-11 Thread Hugh Dickins
On Wed, 11 Jul 2012, Cong Wang wrote: > On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins wrote: > > Revert 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE"). > > I believe it's correct, and it's been nice to have from rc1 to rc6; > > but as the original commit said: > > > > I don't know who

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-11 Thread Hugh Dickins
On Wed, 11 Jul 2012, Cong Wang wrote: On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins hu...@google.com wrote: Revert 4fb5ef089b28 (tmpfs: support SEEK_DATA and SEEK_HOLE). I believe it's correct, and it's been nice to have from rc1 to rc6; but as the original commit said: I don't know

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-11 Thread Dave Chinner
On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: On Wed, 11 Jul 2012, Cong Wang wrote: On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins hu...@google.com wrote: Revert 4fb5ef089b28 (tmpfs: support SEEK_DATA and SEEK_HOLE). I believe it's correct, and it's been nice to have from

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-11 Thread Hugh Dickins
On Thu, 12 Jul 2012, Dave Chinner wrote: On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: On Wed, 11 Jul 2012, Cong Wang wrote: If you don't have burden to maintain it, I'd prefer to leave as it is, I don't think 752-bytes is the reason we revert it. Thank you, your

Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-11 Thread Jeff Liu
On 07/12/2012 07:01 AM, Dave Chinner wrote: On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote: On Wed, 11 Jul 2012, Cong Wang wrote: On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins hu...@google.com wrote: Revert 4fb5ef089b28 (tmpfs: support SEEK_DATA and SEEK_HOLE). I believe it's

[PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-09 Thread Hugh Dickins
Revert 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE"). I believe it's correct, and it's been nice to have from rc1 to rc6; but as the original commit said: I don't know who actually uses SEEK_DATA or SEEK_HOLE, and whether it would be of any use to them on tmpfs. This code adds 92 lines

[PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE

2012-07-09 Thread Hugh Dickins
Revert 4fb5ef089b28 (tmpfs: support SEEK_DATA and SEEK_HOLE). I believe it's correct, and it's been nice to have from rc1 to rc6; but as the original commit said: I don't know who actually uses SEEK_DATA or SEEK_HOLE, and whether it would be of any use to them on tmpfs. This code adds 92 lines