Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-14 Thread Jarkko Sakkinen
On Sat, Feb 13, 2016 at 11:50:08PM -0700, Jason Gunthorpe wrote: > On Sun, Feb 14, 2016 at 06:55:12AM +0200, Jarkko Sakkinen wrote: > > On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > > > This was missed during the struct device conversion, we > > > need to hold a kref on the

Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-14 Thread Jarkko Sakkinen
On Sat, Feb 13, 2016 at 11:50:08PM -0700, Jason Gunthorpe wrote: > On Sun, Feb 14, 2016 at 06:55:12AM +0200, Jarkko Sakkinen wrote: > > On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > > > This was missed during the struct device conversion, we > > > need to hold a kref on the

Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-13 Thread Jason Gunthorpe
On Sun, Feb 14, 2016 at 06:55:12AM +0200, Jarkko Sakkinen wrote: > On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > > This was missed during the struct device conversion, we > > need to hold a kref on the chip to make sure it isn't freed. > > > > Signed-off-by: Jason Gunthorpe

Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-13 Thread Jarkko Sakkinen
On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > This was missed during the struct device conversion, we > need to hold a kref on the chip to make sure it isn't freed. > > Signed-off-by: Jason Gunthorpe I'm bit confused about this patch. What is the regression if this needs to

Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-13 Thread Jason Gunthorpe
Hi Jarkko, I found a bug in this last night, please hold off. Jason On Feb 13, 2016 3:08 AM, Jarkko Sakkinen wrote: > > On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > > This was missed during the struct device conversion, we > > need to hold a kref on the chip to make

Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-13 Thread Jarkko Sakkinen
On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > This was missed during the struct device conversion, we > need to hold a kref on the chip to make sure it isn't freed. > > Signed-off-by: Jason Gunthorpe Reviewed-by: Jarkko Sakkinen For rest of the patches I'll look at them

Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-13 Thread Jarkko Sakkinen
On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > This was missed during the struct device conversion, we > need to hold a kref on the chip to make sure it isn't freed. > > Signed-off-by: Jason Gunthorpe Reviewed-by: Jarkko Sakkinen

Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-13 Thread Jason Gunthorpe
Hi Jarkko, I found a bug in this last night, please hold off. Jason On Feb 13, 2016 3:08 AM, Jarkko Sakkinen wrote: > > On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > > This was missed during the struct device conversion, we > > need to

Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-13 Thread Jarkko Sakkinen
On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > This was missed during the struct device conversion, we > need to hold a kref on the chip to make sure it isn't freed. > > Signed-off-by: Jason Gunthorpe I'm bit confused about this patch. What

Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-13 Thread Jason Gunthorpe
On Sun, Feb 14, 2016 at 06:55:12AM +0200, Jarkko Sakkinen wrote: > On Fri, Feb 12, 2016 at 05:04:29PM -0700, Jason Gunthorpe wrote: > > This was missed during the struct device conversion, we > > need to hold a kref on the chip to make sure it isn't freed. > > > > Signed-off-by: Jason Gunthorpe

[PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-12 Thread Jason Gunthorpe
This was missed during the struct device conversion, we need to hold a kref on the chip to make sure it isn't freed. Signed-off-by: Jason Gunthorpe --- drivers/char/tpm/tpm-chip.c | 2 ++ drivers/char/tpm/tpm.h | 1 + 2 files changed, 3 insertions(+) diff --git

[PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get

2016-02-12 Thread Jason Gunthorpe
This was missed during the struct device conversion, we need to hold a kref on the chip to make sure it isn't freed. Signed-off-by: Jason Gunthorpe --- drivers/char/tpm/tpm-chip.c | 2 ++ drivers/char/tpm/tpm.h | 1 + 2 files changed, 3 insertions(+) diff