Re: [PATCH 1/3] tracing: correctly expand len expressions from __dynamic_array macro

2014-03-03 Thread Filipe Brandenburger
Hi Steve, I don't think this needs to be backported to stable, since the only place that uses the high 16 bits of the offset field as the length is filter_pred_strloc which only works for strings and sizeof(char) == 1 so that essentially whenever the bug is triggered, the actual stored value is

Re: [PATCH 1/3] tracing: correctly expand len expressions from __dynamic_array macro

2014-03-03 Thread Steven Rostedt
On Fri, 28 Feb 2014 21:32:16 -0800 Filipe Brandenburger wrote: > This fixes expansion of the len argument in __dynamic_array macros. > The previous code from commit 7d536cb3f would not fully evaluate the > expression before multiplying its result by the size of the type. > > This went unnoticed

Re: [PATCH 1/3] tracing: correctly expand len expressions from __dynamic_array macro

2014-03-03 Thread Steven Rostedt
On Fri, 28 Feb 2014 21:32:16 -0800 Filipe Brandenburger filbran...@google.com wrote: This fixes expansion of the len argument in __dynamic_array macros. The previous code from commit 7d536cb3f would not fully evaluate the expression before multiplying its result by the size of the type.

Re: [PATCH 1/3] tracing: correctly expand len expressions from __dynamic_array macro

2014-03-03 Thread Filipe Brandenburger
Hi Steve, I don't think this needs to be backported to stable, since the only place that uses the high 16 bits of the offset field as the length is filter_pred_strloc which only works for strings and sizeof(char) == 1 so that essentially whenever the bug is triggered, the actual stored value is

[PATCH 1/3] tracing: correctly expand len expressions from __dynamic_array macro

2014-02-28 Thread Filipe Brandenburger
This fixes expansion of the len argument in __dynamic_array macros. The previous code from commit 7d536cb3f would not fully evaluate the expression before multiplying its result by the size of the type. This went unnoticed because the length stored in the high 16 bits of the offset (which is the

[PATCH 1/3] tracing: correctly expand len expressions from __dynamic_array macro

2014-02-28 Thread Filipe Brandenburger
This fixes expansion of the len argument in __dynamic_array macros. The previous code from commit 7d536cb3f would not fully evaluate the expression before multiplying its result by the size of the type. This went unnoticed because the length stored in the high 16 bits of the offset (which is the