Re: [PATCH 1/3] tracing: merge seq_print_sym_short() and seq_print_sym_offset()

2018-10-26 Thread Steven Rostedt
Hi Ramus, Thanks for sending these patches. I have some small nits though. First, please send a cover letter whenever sending more than one patch. It just groups them better in my inbox. The second is embedded below. On Fri, 26 Oct 2018 23:13:44 +0200 Rasmus Villemoes wrote: > These two

Re: [PATCH 1/3] tracing: merge seq_print_sym_short() and seq_print_sym_offset()

2018-10-26 Thread Steven Rostedt
Hi Ramus, Thanks for sending these patches. I have some small nits though. First, please send a cover letter whenever sending more than one patch. It just groups them better in my inbox. The second is embedded below. On Fri, 26 Oct 2018 23:13:44 +0200 Rasmus Villemoes wrote: > These two

[PATCH 1/3] tracing: merge seq_print_sym_short() and seq_print_sym_offset()

2018-10-26 Thread Rasmus Villemoes
These two functions are nearly identical, so we can avoid some code duplication by moving the conditional into a common implementation. Signed-off-by: Rasmus Villemoes --- kernel/trace/trace_output.c | 34 +++--- 1 file changed, 7 insertions(+), 27 deletions(-) diff

[PATCH 1/3] tracing: merge seq_print_sym_short() and seq_print_sym_offset()

2018-10-26 Thread Rasmus Villemoes
These two functions are nearly identical, so we can avoid some code duplication by moving the conditional into a common implementation. Signed-off-by: Rasmus Villemoes --- kernel/trace/trace_output.c | 34 +++--- 1 file changed, 7 insertions(+), 27 deletions(-) diff