Re: [PATCH 1/3] uprobes/x86: Rename *riprel* helpers to make the naming consistent

2014-04-30 Thread Jim Keniston
On Mon, 2014-04-28 at 12:04 +0530, Srikar Dronamraju wrote: > * Oleg Nesterov [2014-04-27 18:52:23]: > > > handle_riprel_insn(), pre_xol_rip_insn() and handle_riprel_post_xol() > > look confusing and inconsistent. Rename them into riprel_analyze(), > > riprel_pre_xol(), and riprel_post_xol() resp

Re: [PATCH 1/3] uprobes/x86: Rename *riprel* helpers to make the naming consistent

2014-04-27 Thread Srikar Dronamraju
* Oleg Nesterov [2014-04-27 18:52:23]: > handle_riprel_insn(), pre_xol_rip_insn() and handle_riprel_post_xol() > look confusing and inconsistent. Rename them into riprel_analyze(), > riprel_pre_xol(), and riprel_post_xol() respectively. > > No changes in compiled code. > > Signed-off-by: Oleg N

[PATCH 1/3] uprobes/x86: Rename *riprel* helpers to make the naming consistent

2014-04-27 Thread Oleg Nesterov
handle_riprel_insn(), pre_xol_rip_insn() and handle_riprel_post_xol() look confusing and inconsistent. Rename them into riprel_analyze(), riprel_pre_xol(), and riprel_post_xol() respectively. No changes in compiled code. Signed-off-by: Oleg Nesterov --- arch/x86/kernel/uprobes.c | 24