Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure

2013-11-30 Thread Evgeniy Polyakov
Hi 29.11.2013, 15:40, "Alexander Shiyan" : > Private field "clkdiv" is not used outside "probe", so there are > no reason to keep it in driver. The whole serie looks good, thank you Greg, please pull it into your tree > Signed-off-by: Alexander Shiyan Acked-by: Evgeniy Polyakov -- To

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field clkdiv from private structure

2013-11-30 Thread Evgeniy Polyakov
Hi 29.11.2013, 15:40, Alexander Shiyan shc_w...@mail.ru: Private field clkdiv is not used outside probe, so there are no reason to keep it in driver. The whole serie looks good, thank you Greg, please pull it into your tree Signed-off-by: Alexander Shiyan shc_w...@mail.ru Acked-by: Evgeniy

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure

2013-11-29 Thread Marc Kleine-Budde
On 11/29/2013 12:56 PM, Alexander Shiyan wrote: >> On 11/29/2013 12:39 PM, Alexander Shiyan wrote: >>> Private field "clkdiv" is not used outside "probe", so there are >>> no reason to keep it in driver. >> >> Where's the corresponding clk_disable_unprepare()? > > I do not see any relation

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure

2013-11-29 Thread Alexander Shiyan
> On 11/29/2013 12:39 PM, Alexander Shiyan wrote: > > Private field "clkdiv" is not used outside "probe", so there are > > no reason to keep it in driver. > > Where's the corresponding clk_disable_unprepare()? I do not see any relation "clk_disable_unprepare" with this patch. ---

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure

2013-11-29 Thread Marc Kleine-Budde
On 11/29/2013 12:39 PM, Alexander Shiyan wrote: > Private field "clkdiv" is not used outside "probe", so there are > no reason to keep it in driver. Where's the corresponding clk_disable_unprepare()? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial

[PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure

2013-11-29 Thread Alexander Shiyan
Private field "clkdiv" is not used outside "probe", so there are no reason to keep it in driver. Signed-off-by: Alexander Shiyan --- drivers/w1/masters/mxc_w1.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c

[PATCH 1/3] w1: mxc_w1: Remove unused field clkdiv from private structure

2013-11-29 Thread Alexander Shiyan
Private field clkdiv is not used outside probe, so there are no reason to keep it in driver. Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- drivers/w1/masters/mxc_w1.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/w1/masters/mxc_w1.c

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field clkdiv from private structure

2013-11-29 Thread Marc Kleine-Budde
On 11/29/2013 12:39 PM, Alexander Shiyan wrote: Private field clkdiv is not used outside probe, so there are no reason to keep it in driver. Where's the corresponding clk_disable_unprepare()? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field clkdiv from private structure

2013-11-29 Thread Alexander Shiyan
On 11/29/2013 12:39 PM, Alexander Shiyan wrote: Private field clkdiv is not used outside probe, so there are no reason to keep it in driver. Where's the corresponding clk_disable_unprepare()? I do not see any relation clk_disable_unprepare with this patch. ---

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field clkdiv from private structure

2013-11-29 Thread Marc Kleine-Budde
On 11/29/2013 12:56 PM, Alexander Shiyan wrote: On 11/29/2013 12:39 PM, Alexander Shiyan wrote: Private field clkdiv is not used outside probe, so there are no reason to keep it in driver. Where's the corresponding clk_disable_unprepare()? I do not see any relation clk_disable_unprepare